Page MenuHomePhabricator
Create Task
Maniphest T213477

Caption language name is displayed in page language, rather than as autonym, for filled-in captions
Closed, ResolvedPublic
Actions

Description

Whoops.

Details

SubjectRepoBranchLines +/-
CaptionsPanel: Always use `$.uls.data.getAutonym` for language namemediawiki/extensions/WikibaseMediaInfomaster+4 -5
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Jan 10 2019, 8:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2019, 8:20 PM
Jdforrester-WMF mentioned this in T209016: Is it correct to show RTL content in RTL display mode alongside LTR content in LTR display mode?.Jan 10 2019, 8:21 PM
gerritbot subscribed.Jan 10 2019, 8:42 PM

Change 483512 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] CaptionsPanel: Always use $.uls.data.getAutonym for language name

https://gerrit.wikimedia.org/r/483512

gerritbot added a project: Patch-For-Review.Jan 10 2019, 8:42 PM
Jdforrester-WMF merged a task: T213241: Direction of language name should conform to UI language and not the language itself.Jan 10 2019, 8:42 PM
Jdforrester-WMF added subscribers: Ladsgroup, • Ramsey-WMF, Cparle.
Jdforrester-WMF mentioned this in rEWBI9d7d7005f901: CaptionsPanel: Always use `$.uls.data.getAutonym` for language name.Jan 10 2019, 8:44 PM
Jdforrester-WMF mentioned this in rEWBIcd71cb7d6d17: CaptionsPanel: Always use `$.uls.data.getAutonym` for language name.Jan 10 2019, 8:49 PM
Jdforrester-WMF mentioned this in rEWBIfde492a25c62: CaptionsPanel: Always use `$.uls.data.getAutonym` for language name.Jan 10 2019, 9:20 PM
gerritbot added a comment.Jan 10 2019, 10:47 PM

Change 483512 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] CaptionsPanel: Always use $.uls.data.getAutonym for language name

https://gerrit.wikimedia.org/r/483512

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 10 2019, 11:01 PM
Jdforrester-WMF claimed this task.EditedJan 11 2019, 5:49 PM
Jdforrester-WMF edited projects, added Structured Data Engineering; removed Patch-For-Review.

@Ladsgroup, new layout with the fixes:

interface language=en
image.png (820×1 px, 79 KB)
interface language=he
image.png (811×1 px, 72 KB)

Does that work for you? Moriel said the placeholder should remain as-is.

Jdforrester-WMF moved this task from To Do to Verify on Production on the Structured Data Engineering board.Jan 11 2019, 5:49 PM
Jdforrester-WMF added a project: Multimedia-Team-Working-Board.Jan 11 2019, 10:22 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptJan 11 2019, 10:22 PM
Jdforrester-WMF moved this task from Untriaged to Product owner backlog on the Multimedia board.Jan 11 2019, 10:22 PM
Jdforrester-WMF moved this task from To Do to Ready for Production Testing on the Multimedia-Team-Working-Board board.Jan 14 2019, 5:26 PM
• Ramsey-WMF closed this task as Resolved.Jan 17 2019, 9:01 PM

Confirmed on production (with new alignment/layout)

jijiki mentioned this in rEWBIaaa833e7c854: CaptionsPanel: Always use `$.uls.data.getAutonym` for language name.Mar 18 2019, 4:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL