Wikibase hijacks search autocomplete frontend entirely; we should configure it off
Closed, ResolvedPublic

Description

  1. Go to https://commons.wikimedia.org/wiki/Main_Page
  2. Type "User:MarkT" into the search bar in the upper right
  3. Observe infinite spinning wheel of doom while waiting for an autocomplete

Bonus intel:

A. repo/resources/wikibase.ui.entitysearch.js is the spot where the search bar is hijacked, turning it into a search for only Wikidata items. Did I say Wikidata? Yes. Because...
B. repo/resources/jquery.wikibase/jquery.wikibase.entityselector.js has a default entity type of 'item', and there doesn't appear to be any configuration for adding or overriding.
C. It would be great if not only we could configure the entitysearch widget to work for mediainfo entities, but also put the normal suggestions (for user pages, project pages, etc.) alongside them somehow. I suspect that may be a UX thing we haven't figured out yet, given the current state of search.

This is a pretty major user-facing breaking change due to the SDC rollout today, it would be super to fix it up ASAP.

Restricted Application added a project: Wikidata. · View Herald TranscriptThu, Jan 10, 11:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 483630 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] [Commons, TestCommons] Don't use Wikibase entity search

https://gerrit.wikimedia.org/r/483630

Change 483630 merged by jenkins-bot:
[operations/mediawiki-config@master] [Commons, TestCommons] Don't use Wikibase entity search

https://gerrit.wikimedia.org/r/483630

Jdforrester-WMF renamed this task from Wikibase hijacks search autocomplete frontend entirely, and isn't configurable to Wikibase hijacks search autocomplete frontend entirely; we should configure it off.Thu, Jan 10, 11:34 PM
Jdforrester-WMF claimed this task.

Mentioned in SAL (#wikimedia-operations) [2019-01-10T23:36:18Z] <jforrester@deploy1001> Synchronized wmf-config/Wikibase.php: T213497 [Commons, TestCommons] Don't use Wikibase entity search (duration: 00m 46s)

Jdforrester-WMF moved this task from To Do to Sign off on the SDC Engineering board.

Fixed. Config was added in T205560.

Addshore moved this task from incoming to in progress on the Wikidata board.Thu, Jan 10, 11:36 PM
Jdforrester-WMF closed this task as Resolved.Fri, Jan 11, 10:23 PM

Declaring this Resolved.