CSS classes should be prefixed
Closed, ResolvedPublic
Actions

Description

Several classes are generically named, raising the likelihood of a conflict, e.g.

viewMore
viewLess
entity-term
editActions

Class names should have an extension-specific prefix as per https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS

Details

	Subject	Repo	Branch	Lines +/-
	Clean up all CSS classnames, prefixing all of ours with "wbmi-"	mediawiki/extensions/WikibaseMediaInfo	master	+136 -140

Customize query in gerrit

Related Objects

Mentioned In: rEWBI076d9b03804a: Clean up all CSS classnames, prefixing all of ours with "wbmi-"
T214607: Summary header vanishes when a file doesn't have any captions entered
rEWBId1738c877111: Clean up all CSS classnames, prefixing all of ours with "wbmi-"

Event Timeline

Esanders created this task.Jan 12 2019, 11:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2019, 11:26 PM

This will be changed as part of upcoming development this week probably.

Assigning to Cormac for now, to be done later in the week

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Jan 14 2019, 7:17 PM

Change 484595 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Clean up all CSS classnames, prefixing all of ours with "wbmi-"

https://gerrit.wikimedia.org/r/484595

gerritbot added a project: Patch-For-Review.Jan 15 2019, 11:48 PM

Jdforrester-WMF mentioned this in rEWBId1738c877111: Clean up all CSS classnames, prefixing all of ours with "wbmi-".Jan 15 2019, 11:48 PM

Jdforrester-WMF claimed this task.Jan 15 2019, 11:53 PM

Jdforrester-WMF moved this task from To Do to Code Review on the Multimedia-Team-Working-Board board.

Jdforrester-WMF added a subscriber: Cparle.

Change 484595 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Clean up all CSS classnames, prefixing all of ours with "wbmi-"

https://gerrit.wikimedia.org/r/484595

Will go out in next week's train (except for the final removal of filepage-mediainfo-entitytermsview, which we'll drop after people have had a chance to switch over.

Jdforrester-WMF removed a project: Patch-For-Review.Jan 16 2019, 6:41 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.14; 2019-01-22).Jan 16 2019, 7:00 PM

AlexisJazz mentioned this in T214607: Summary header vanishes when a file doesn't have any captions entered.Jan 24 2019, 5:35 PM

Verified in the CSS on production.

jijiki mentioned this in rEWBI076d9b03804a: Clean up all CSS classnames, prefixing all of ours with "wbmi-".Mar 18 2019, 4:26 PM

CSS classes should be prefixedClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

CSS classes should be prefixed
Closed, ResolvedPublic
Actions