Page MenuHomePhabricator
Create Task
Maniphest T213776

[BUG] Captions freezes when user injects illegal language codes that MediaWiki doesn't support
Closed, ResolvedPublic
Actions

Description

I have cmn on my userpage. When I click the pen button, I get this because cmn is not available.

<div data-caption-languages="en,cmn,de,yue,zh" class="filepage-mediainfo-entitytermsview oo-ui-layout oo-ui-panelLayout oo-ui-panelLayout-framed oo-ui-pendingElement-pending">

Unsupported babelcodes should be ignored to avoid this I guess?

Details

SubjectRepoBranchLines +/-
CaptionsPanel.getCaptionLanguagesList: Drop unknown languagesmediawiki/extensions/WikibaseMediaInfomaster+7 -1
Customize query in gerrit

Related Objects

Event Timeline

Roy17 created this task.Jan 15 2019, 12:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2019, 12:24 AM
Aklapper closed this task as a duplicate of T213571: Ignore babel box the user has set to knowing at level 0 on Commons (and so have different behaviour to Wikidata).Jan 15 2019, 3:09 AM
Roy17 reopened this task as Open.Jan 15 2019, 5:21 AM

@Aklapper This is not the same.

cmn is ISO 639-3 code for Mandarin Chinese, which I speak natively, but this code is not recognised by the captions feature. The same problem can occur for aaa (Ghotuo language) and so on.

Roy17 added a comment.Jan 15 2019, 5:19 PM

It freezes at this state. The code I gave was from checking the html.

Roy17 added a project: Structured Data Engineering.Jan 16 2019, 5:59 PM
Roy17 unsubscribed.
Jdforrester-WMF renamed this task from [BUG] captions freezes when babelcodes are not available to [BUG] Captions freezes when user injects illegal language codes that MediaWiki doesn't support.Jan 16 2019, 6:06 PM
Jdforrester-WMF claimed this task.
gerritbot subscribed.Jan 17 2019, 12:49 AM

Change 484810 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] CaptionsPanel.getCaptionLanguagesList: Drop unknown languages

https://gerrit.wikimedia.org/r/484810

gerritbot added a project: Patch-For-Review.Jan 17 2019, 12:49 AM
Jdforrester-WMF moved this task from To Do to Doing on the Structured Data Engineering board.Jan 17 2019, 12:49 AM
Jdforrester-WMF mentioned this in rEWBI983935065386: CaptionsPanel.getCaptionLanguagesList: Drop unknown languages.Jan 17 2019, 12:51 AM
Jdforrester-WMF mentioned this in rEWBI98c14513b29d: CaptionsPanel.getCaptionLanguagesList: Drop unknown languages.Jan 17 2019, 7:47 PM
gerritbot added a comment.Jan 18 2019, 11:51 AM

Change 484810 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] CaptionsPanel.getCaptionLanguagesList: Drop unknown languages

https://gerrit.wikimedia.org/r/484810

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.14; 2019-01-22).Jan 18 2019, 12:00 PM
Jdforrester-WMF moved this task from Doing to Verify on Production on the Structured Data Engineering board.Jan 18 2019, 5:10 PM
Jdforrester-WMF removed a project: Patch-For-Review.
• Ramsey-WMF closed this task as Resolved.Feb 6 2019, 6:08 PM
• Ramsey-WMF subscribed.

Tested on production with cmn-0. Works.

greg added a project: Multimedia.Mar 7 2019, 10:59 PM
jijiki mentioned this in rEWBIab13df2a25ba: CaptionsPanel.getCaptionLanguagesList: Drop unknown languages.Mar 18 2019, 4:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL