Page MenuHomePhabricator

Default the To language dropdown to 'Select a language' and disable inputs until a language is selected
Closed, ResolvedPublic2 Estimated Story Points

Description

This was in the spec in T206712: Create the Translate view but got overlooked.

Current behavior

The To language dropdown defaults to user's chosen language for UI.

image.png (112×1 px, 15 KB)

Desired behavior

  1. The To language dropdown by default always shows Select a language string. It does not matter what language(s) the user has added to their settings. They need to pick the language they want to translate to always. This string itself is localized into the language chosen by the user as the tool language. Opening this dropdown shows the ULS, as expected.

image.png (122×1 px, 17 KB)

  1. Users should not be able to add translation labels unless they pick a language. The inputs are disabled until a To language has been selected.

Related Objects

Event Timeline

Niharika triaged this task as Medium priority.Jan 17 2019, 3:31 AM
Niharika created this task.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Niharika renamed this task from Default the To language dropdown to 'Select a language' to Default the To language dropdown to 'Select a language' and disable inputs until a language is selected.Jan 22 2019, 7:06 AM
Niharika updated the task description. (Show Details)
Niharika set the point value for this task to 2.Jan 23 2019, 12:14 AM
Niharika added a subscriber: Mooeypoo.

@MaxSem: From a conversation with @Mooeypoo it seems like there is some confusion on what the desired behavior is here. I've made it clearer in the ticket.

In general, I'd caution against making assumptions that aren't in the ticket. Asking clarifying questions is always great!

Niharika moved this task from QA to Q3 2018-19 on the Community-Tech-Sprint board.
Niharika moved this task from In progress to Done on the SVG Translate Tool board.