Page MenuHomePhabricator
Create Task
Maniphest T214053

Hide "show in all languages" link in absence of CSR
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

As a user without enabled JS I want to be presented only with interactive user interface elements that suggest an interactive nature (links, buttons) which actually do have an implemented behavior in the server side so that a consistent browsing experience is achieved and I am not frustrated by a lack of feature.

AC

  • the "show in all languages" link and section is not visible in absence of CSR

Note

  • the "show in all languages" link is available in CSR via T205261
  • this is to be done after T211865
  • this can/will be reconsidered once link/section toggle state can be taken into account by mw/wb view rendering

Details

SubjectRepoBranchLines +/-
termbox: update to latestmediawiki/extensions/Wikibasemaster+1 -1
Hide "all entered languages" section and button on the server sidewikibase/termboxmaster+137 -10
Customize query in gerrit

Related Objects

Event Timeline

• Pablo-WMDE created this task.Jan 17 2019, 3:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2019, 3:27 PM
• Pablo-WMDE updated the task description. (Show Details)Jan 17 2019, 3:36 PM
Lea_WMDE moved this task from Backlog to MVP tickets: In preparation on the Wikidata-Termbox board.Jan 21 2019, 10:19 AM
Lydia_Pintscher added a project: Wikidata.Jan 26 2019, 1:03 PM
Lea_WMDE set the point value for this task to 3.Jan 30 2019, 3:17 PM
Lea_WMDE moved this task from MVP tickets: In preparation to MVP things: Ready for pickup on the Wikidata-Termbox board.
Jakob_WMDE claimed this task.Feb 1 2019, 1:43 PM
Jakob_WMDE edited projects, added Wikidata-Termbox-Iteration-8; removed Wikidata-Termbox.
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-8 board.
gerritbot subscribed.Feb 1 2019, 3:30 PM

Change 487502 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Hide "all entered languages" section and button on the server side

https://gerrit.wikimedia.org/r/487502

gerritbot added a project: Patch-For-Review.Feb 1 2019, 3:30 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-8 board.Feb 1 2019, 3:53 PM
gerritbot added a comment.Feb 5 2019, 9:23 AM

Change 487502 merged by jenkins-bot:
[wikibase/termbox@master] Hide "all entered languages" section and button on the server side

https://gerrit.wikimedia.org/r/487502

gerritbot added a comment.Feb 5 2019, 10:24 AM

Change 488018 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: update to latest

https://gerrit.wikimedia.org/r/488018

gerritbot added a comment.Feb 5 2019, 12:38 PM

Change 488018 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: update to latest

https://gerrit.wikimedia.org/r/488018

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Feb 5 2019, 1:00 PM
Jakob_WMDE removed Jakob_WMDE as the assignee of this task.Feb 5 2019, 1:04 PM
Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Termbox-Iteration-8 board.
Jakob_WMDE subscribed.
• Pablo-WMDE added a subscriber: Lea_WMDE.Feb 7 2019, 10:47 AM

@Lea_WMDE Can be observed at e.g. https://wikidata.beta.wmflabs.org/w/index.php?title=Item:Q11&useformat=mobile&uselang=de (in the absence of JS, of course; see https://www.technipages.com/firefox-enable-disable-javascript if you dare)

Lea_WMDE closed this task as Resolved.Feb 8 2019, 10:17 AM
Lea_WMDE claimed this task.
Lea_WMDE moved this task from Test (Product Review) to Done on the Wikidata-Termbox-Iteration-8 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL