Page MenuHomePhabricator
Create Task
Maniphest T214479

Remove link appearance of "More languages" in absence of CSR
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
• Lea_WMDE
Authored By
• Lea_WMDE
Jan 23 2019, 3:01 PM
Tags
Referenced Files
F28148565: Screenshot from 2019-02-07 18-23-11.png
Feb 7 2019, 5:28 PM
F28148395: Screenshot 2019-02-07 at 17.51.01.png
Feb 7 2019, 4:51 PM
F28148389: Screenshot 2019-02-07 at 17.50.29.png
Feb 7 2019, 4:51 PM
Subscribers
Aklapper
gerritbot
• Hanna_Petruschat_WMDE
Jakob_WMDE
• Lea_WMDE

Description

As a user without enabled JS
I want to be presented only with interactive user interface elements that suggest an interactive nature (links, buttons) which actually do have an implemented behavior in the server side
so that a consistent browsing experience is achieved and I am not frustrated by a lack of feature.

AC

  • the "in more languages" link is not a link in absence of CSR, but just a title. This means, that
    • hovering does not result in any response by the browser
    • there is no arrow sign in the interactive side bar

Details

SubjectRepoBranchLines +/-
termbox: update to latestmediawiki/extensions/Wikibasemaster+1 -1
termbox: update to latestmediawiki/extensions/Wikibasemaster+1 -1
toggleButton: unclickable as another modificationwikibase/termboxmaster+10 -1
Remove link appearance from "in more languages" button when SSRedwikibase/termboxmaster+32 -2
Customize query in gerrit

Related Objects

Event Timeline

• Lea_WMDE created this task.Jan 23 2019, 3:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2019, 3:01 PM
Lydia_Pintscher added a project: Wikidata.Jan 26 2019, 1:03 PM
• Lea_WMDE triaged this task as Medium priority.Jan 30 2019, 3:22 PM
• Lea_WMDE updated the task description. (Show Details)
• Lea_WMDE set the point value for this task to 3.
• Lea_WMDE moved this task from MVP tickets: In preparation to MVP things: Ready for pickup on the Wikidata-Termbox board.
Jakob_WMDE claimed this task.Feb 1 2019, 3:59 PM
Jakob_WMDE edited projects, added Wikidata-Termbox-Iteration-8; removed Wikidata-Termbox.
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-8 board.
gerritbot subscribed.Feb 1 2019, 4:26 PM

Change 487507 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Remove link appearance from "in more languages" button when SSRed

https://gerrit.wikimedia.org/r/487507

gerritbot added a project: Patch-For-Review.Feb 1 2019, 4:26 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-8 board.Feb 1 2019, 4:52 PM
gerritbot added a comment.Feb 4 2019, 3:10 PM

Change 487853 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] toggleButton: unclickable as another modification

https://gerrit.wikimedia.org/r/487853

gerritbot added a comment.Feb 5 2019, 9:28 AM

Change 487507 merged by jenkins-bot:
[wikibase/termbox@master] Remove link appearance from "in more languages" button when SSRed

https://gerrit.wikimedia.org/r/487507

gerritbot added a comment.Feb 5 2019, 10:24 AM

Change 487853 merged by jenkins-bot:
[wikibase/termbox@master] toggleButton: unclickable as another modification

https://gerrit.wikimedia.org/r/487853

gerritbot added a comment.Feb 5 2019, 10:24 AM

Change 488018 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: update to latest

https://gerrit.wikimedia.org/r/488018

gerritbot added a comment.Feb 5 2019, 12:38 PM

Change 488018 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: update to latest

https://gerrit.wikimedia.org/r/488018

Jakob_WMDE removed Jakob_WMDE as the assignee of this task.Feb 5 2019, 1:04 PM
Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Termbox-Iteration-8 board.
Jakob_WMDE subscribed.
gerritbot added a comment.Feb 7 2019, 10:41 AM

Change 488898 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: update to latest

https://gerrit.wikimedia.org/r/488898

gerritbot added a comment.Feb 7 2019, 12:15 PM

Change 488898 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: update to latest

https://gerrit.wikimedia.org/r/488898

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 7 2019, 1:00 PM
Jakob_WMDE added a comment.Feb 7 2019, 1:01 PM

@Lea_WMDE this is ready to be looked at https://m.wikidata.beta.wmflabs.org/wiki/Item:Q11?useformat=mobile

• Hanna_Petruschat_WMDE subscribed.Feb 7 2019, 4:47 PM

@Jakob_WMDE Currently if js is disabled, you only see the devider with "In other languages" but no entries at all. Shouldn't this section be expanded? Otherwise there would be no need for this, right?

• Hanna_Petruschat_WMDE added a comment.EditedFeb 7 2019, 4:48 PM

Sorry, I tested in English, apparently it does what it's supposed to do in German...

See:
English

Screenshot 2019-02-07 at 17.50.29.png (638×2 px, 78 KB)

German

Screenshot 2019-02-07 at 17.51.01.png (760×2 px, 116 KB)

Jakob_WMDE added a comment.Feb 7 2019, 5:28 PM

Yup, that's what the old Termbox does as well. It just looks slightly less silly because English appears both in the title and the box below.

Screenshot from 2019-02-07 18-23-11.png (266×936 px, 33 KB)

I don't think this has much to do with this ticket, though. If ever, we need an additional ticket handling the case of an empty "more languages" section, which can only occur in the js-disabled case, I believe.

• Hanna_Petruschat_WMDE added a comment.Feb 7 2019, 5:40 PM

Agreed. I created an extra ticket to cover that issue. You can find it here T215538

• Lea_WMDE closed this task as Resolved.Feb 8 2019, 10:16 AM
• Lea_WMDE claimed this task.
• Lea_WMDE moved this task from Test (Product Review) to Done on the Wikidata-Termbox-Iteration-8 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits