In T214179#4932229, @Ghuron wrote:It looks like it depends whenever PHP7 setting is tuned on or off. When its off, problem disaperars, when its on, action=purge any article that uses it and you will get "false" when calling mw.ext.data.get()
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned In
- T229742: mw.ext.data.get sometimes return false
T215832: PHP Warning: LuaSandboxFunction::call(): Unable to convert object of type stdClass
T214179: mw.ext.data.get Lua call returns false - Mentioned Here
- T176370: Migrate to PHP 7 in WMF production
rMLUS76122a04c696: Remove PHP→Lua object conversion
T214179: mw.ext.data.get Lua call returns false
Event Timeline
Comment Actions
I can't reproduce it returning false, but I can reproduce it returning nil with PHP 7 thanks to rMLUS76122a04c696: Remove PHP→Lua object conversion. With HHVM it's using LuaSandbox version 2.0.14 which doesn't include that patch.
Also, now that I check, if Scribunto is using the LuaStandalone engine then we get an uncaught exception from mw.ext.data.get, and probably have since it was written. Apparently no one ever tested that before.
Comment Actions
Change 488525 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/JsonConfig@master] JCLuaLibrary: Replace objects with arrays, recursively
Comment Actions
Change 488525 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] JCLuaLibrary: Replace objects with arrays, recursively
Comment Actions
Change 488996 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/JsonConfig@wmf/1.33.0-wmf.16] JCLuaLibrary: Replace objects with arrays, recursively
Comment Actions
Change 488996 abandoned by Anomie:
JCLuaLibrary: Replace objects with arrays, recursively
Reason:
No longer needed, it rode the train.