Page MenuHomePhabricator

List tokens use special-cased "bullets" property instead of stuffing it in attribs like other tokens
Closed, ResolvedPublic

Description

This is similar to T205491: QuoteTransformer and quote-tokens use a ".value" property on the token instead of adding it to the token's attributes except for list tokens and the bullets property.

An alternative to stuffing this into attribs[] is to create a derived class ListTagTk on the PHP side that surfaces this property as a first class field.

Event Timeline

ssastry triaged this task as High priority.Feb 8 2019, 6:32 PM

Change 489285 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] ListHandler tokens don't need to be special snowflakes either

https://gerrit.wikimedia.org/r/489285

Change 489285 merged by jenkins-bot:
[mediawiki/services/parsoid@master] ListHandler tokens don't need to be special snowflakes either

https://gerrit.wikimedia.org/r/489285