Burn down FundraisingEmailUnsubscribe extension, rewrite special pages in DonationInterface
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

It's overly complex, relying on convoluted parameter processing and making more things configurable than need be
It uses Twig templates rather than Mustache
It already depends on DonationInterface being installed to use its messages
It duplicates queue settings and logic

Details

Subject	Repo	Branch	Lines +/-
Add Alias for EmailPreferences Special Page	mediawiki/extensions/DonationInterface	master	+1 -0
Rebuild email forms in DonationInterface	mediawiki/extensions/DonationInterface	master	+1 K -1
Extract render class from Mustache gateway form	mediawiki/extensions/DonationInterface	master	+62 -54

Customize query in gerrit

Related Objects

Mentioned In: T224764: Archive the FundraisingEmailUnsubscribe extension

Event Timeline

Ejegg created this task.Mar 12 2019, 10:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2019, 10:49 PM

@Ejegg would this be a good tech talk topic or pairing exercise?

• DStrine moved this task from Triage to Q3 2021-2022 on the Fundraising-Backlog board.Apr 1 2019, 8:11 PM

Change 504987 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] WIP rebuild email forms in DonationInterface

https://gerrit.wikimedia.org/r/504987

gerritbot added a project: Patch-For-Review.Apr 18 2019, 9:06 PM

Change 505058 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Extract render class from Mustache gateway form

https://gerrit.wikimedia.org/r/505058

Ejegg triaged this task as Medium priority.Apr 19 2019, 10:39 PM

Ejegg added a project: Fundraising Sprint Hansel and grep -l.

Ejegg set the point value for this task to 4.

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Hansel and grep -l board.

Ejegg moved this task from Q3 2021-2022 to Current Sprint on the Fundraising-Backlog board.

Change 505058 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Extract render class from Mustache gateway form

https://gerrit.wikimedia.org/r/505058

Change 504987 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rebuild email forms in DonationInterface

https://gerrit.wikimedia.org/r/504987

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 29 2019, 6:01 PM

jgleeson moved this task from Review to Pending Deployment on the Fundraising Sprint Hansel and grep -l board.Apr 30 2019, 10:20 AM

• DStrine added a project: Fundraising Sprint It Came From Out of Scope.Apr 30 2019, 8:23 PM

Change 507719 had a related patch set uploaded (by XenoRyet; owner: XenoRyet):
[mediawiki/extensions/DonationInterface@master] Add Alias for EmailPreferences Special Page

https://gerrit.wikimedia.org/r/507719

Change 507719 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Add Alias for EmailPreferences Special Page

https://gerrit.wikimedia.org/r/507719

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.4; 2019-05-07); removed MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).May 2 2019, 12:00 AM

Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint It Came From Out of Scope board.May 2 2019, 1:46 AM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint It Came From Out of Scope board.May 7 2019, 8:39 PM

• DStrine closed this task as Resolved.May 14 2019, 7:52 PM

Umherirrender mentioned this in T224764: Archive the FundraisingEmailUnsubscribe extension.May 31 2019, 8:22 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 28 2020, 1:10 PM