Page MenuHomePhabricator

Schemas aren't parser cached
Closed, ResolvedPublic

Description

Earlier today I noticed that changes I did to the code generating Schema html were reflected in my wiki pages immediately (without the usual purging): Apparently we don't parser cache schemas right now. Looking into the html source also shows that the <!-- Saved in parser cache with key … and timestamp 20190313004841 and revision id 58 which ParserCache::save prepends to the output html is missing.

Event Timeline

hoo created this task.Mar 16 2019, 1:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2019, 1:09 AM
hoo moved this task from Backlog to Doing on the Shape Expressions Sprint 4 board.Mar 16 2019, 1:09 AM

Change 497017 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseSchema@master] Add isParserCacheSupported -> true

https://gerrit.wikimedia.org/r/497017

hoo claimed this task.Mar 16 2019, 1:18 AM
hoo moved this task from Doing to Peer Review on the Shape Expressions Sprint 4 board.

Change 497017 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Add isParserCacheSupported -> true

https://gerrit.wikimedia.org/r/497017

Lea_Lacroix_WMDE closed this task as Resolved.Mar 21 2019, 9:01 AM
Lea_Lacroix_WMDE moved this task from Verification to Done on the Shape Expressions Sprint 4 board.