Page MenuHomePhabricator
Create Task
Maniphest T218522

SPARQL incorrectly changes URI's from http to https
Closed, ResolvedPublic
Actions

Description

https://www.wikidata.org/wiki/Special:EntityData/Q1455955.rdf contains "<wdtn:P214 rdf:resource="http://viaf.org/viaf/5853377"/>", but if I ask the SPARQL I get https:

SELECT ?viafwikidata WHERE { wd:Q1455955 wdtn:P214 ?viafwikidata }

https://query.wikidata.org/#SELECT%20%3Fviafwikidata%20WHERE%20%7B%20wd%3AQ1455955%20wdtn%3AP214%20%3Fviafwikidata%20%7D

Returns https://viaf.org/viaf/5853377

https://www.wikidata.org/wiki/Property:P214 has the right formatter URI. We talked about this at https://www.wikidata.org/w/index.php?title=Topic:Uk2brgqgg1al95f1 and this seems to be historic behavior to normalize outgoing links. https://www.w3.org/DesignIssues/Security-NotTheS.html explains why this is wrong and breaks things. See for example https://www.wikidata.org/wiki/Property_talk:P1006/Mismatches for a query that breaks.

Details

SubjectRepoBranchLines +/-
Followup on invalid VIAF https conversionwikidata/query/rdfmaster+4 -4
Update vocabularies to use correct URL for VIAFwikidata/query/rdfmaster+43 -8
Customize query in gerrit

Related Objects

Event Timeline

Multichill created this task.Mar 17 2019, 9:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2019, 9:22 PM
Base subscribed.Mar 17 2019, 10:16 PM
Smalyshev triaged this task as Medium priority.Mar 20 2019, 12:19 AM
Smalyshev updated the task description. (Show Details)May 2 2019, 9:36 PM
Smalyshev mentioned this in T222404: Tasks requiring Blazegraph reload.
Smalyshev moved this task from Incoming to Current work on the Wikidata-Query-Service board.Jun 18 2019, 10:25 PM
gerritbot added a comment.Jun 18 2019, 11:34 PM

Change 517770 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[wikidata/query/rdf@master] Update vocabularies to use correct URL for VIAF

https://gerrit.wikimedia.org/r/517770

gerritbot added a project: Patch-For-Review.Jun 18 2019, 11:34 PM
Smalyshev added a comment.Jun 20 2019, 12:57 AM

This will require DB reload, so will be handled when that happens.

gerritbot added a comment.Jun 20 2019, 6:05 AM

Change 517770 merged by jenkins-bot:
[wikidata/query/rdf@master] Update vocabularies to use correct URL for VIAF

https://gerrit.wikimedia.org/r/517770

Smalyshev added a project: Discovery-Wikidata-Query-Service-Sprint.Jun 20 2019, 6:06 AM
Smalyshev moved this task from Backlog to Done on the Discovery-Wikidata-Query-Service-Sprint board.
Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 6:10 AM
Smalyshev claimed this task.Jun 20 2019, 7:12 PM
Esc3300 subscribed.EditedJun 26 2019, 12:25 PM

Is is just an impression or do we now get redirected through http: when clicking on a Wikidata item on results on a https-connection WQS?

It would probably be preferable to convert the entire thing to https.

Smalyshev added a comment.Jun 26 2019, 3:50 PM

It is important to not confuse the data access URL with the identifier URI. Identifier URI should be the same for all Linked Data applications, so that they know it's the same thing. Data access URL can be anything as long as it delivers data (and in general identifier URI doesn't even have to produce any data though it's a good form to have it produce or redirect to something). Looks like correct identifier for VIAF has http.

Multichill added a comment.Jun 29 2019, 8:46 AM
In T218522#5285888, @Esc3300 wrote:

Is is just an impression or do we now get redirected through http: when clicking on a Wikidata item on results on a https-connection WQS?

It would probably be preferable to convert the entire thing to https.

Have a look at https://www.w3.org/DesignIssues/Security-NotTheS.html

Smalyshev closed this task as Resolved.Jul 21 2019, 8:01 PM
gerritbot added a comment.Apr 9 2020, 6:02 PM

Change 587835 had a related patch set uploaded (by DCausse; owner: DCausse):
[wikidata/query/rdf@master] Followup on invalid VIAF https conversion

https://gerrit.wikimedia.org/r/587835

gerritbot added a project: Patch-For-Review.Apr 9 2020, 6:02 PM
gerritbot added a comment.Apr 15 2020, 7:58 AM

Change 587835 merged by jenkins-bot:
[wikidata/query/rdf@master] Followup on invalid VIAF https conversion

https://gerrit.wikimedia.org/r/587835

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2020, 8:11 AM
Danmichaelo subscribed.Apr 20 2020, 6:19 PM
Danmichaelo unsubscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits