Page MenuHomePhabricator

Depicts form incorrect state
Closed, ResolvedPublicBUG REPORT


User story: N/A

We have this:
On File page:

  • add a depicts statement
  • while the statement is submitting, and the form is in 'pending' state (with the 'publish' button disabled), quickly add another depicts statement before the api responds
  • after the api response comes back, the form goes back into the 'read' state, even though it should be in the 'edit' state as a new statement has been added ... and when you click 'edit' the 'publish' button is disabled

We want this:

  • simplest solution is probably to disable or hide the 'depicts' input while the form is submitting

Acceptance Criteria:

  • the depicts form no longer goes into incorrect states

Event Timeline

Cparle created this task.Mar 25 2019, 12:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2019, 12:54 PM

Change 498868 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Disable adding new statements while they're being submitted

Ramsey-WMF triaged this task as High priority.Mar 25 2019, 4:39 PM
Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.
Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.

Change 498868 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Disable adding new statements while they're being submitted

ok on test-commons

Ramsey-WMF closed this task as Resolved.Apr 24 2019, 10:58 PM

Tested on production (autosuggest box is disabled during submit of depicts)