Page MenuHomePhabricator
Create Task
Maniphest T219734

Not possible to edit forms of Wikidata lexemes
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

Go to: https://www.wikidata.org/wiki/Lexeme:L12912

Press edit at L12912-F2

Actual Results:

No edit box is shown for the form and its grammatical representation.

Expected Results:

Edit box should be shown.

Details

SubjectRepoBranchLines +/-
Fix GrammaticalFeatureListWidgetmediawiki/extensions/WikibaseLexemewmf/1.33.0-wmf.23+8 -4
Customize query in gerrit

Related Objects

Event Timeline

Fnielsen created this task.Mar 31 2019, 4:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2019, 4:14 PM
Lucas_Werkmeister_WMDE subscribed.Mar 31 2019, 4:24 PM

The console says “TypeError: text.trim is not a function” and then after a second click “TypeError: this._grammaticalFeatureListWidget is null”, so I assume this is the same bug as T219134: `text.trim is not a function` in node selenium tests blocking Wikibase CI; blocking test/merge in WB/WBL/WBMI/etc., and we should backport the fix ASAP.

gerritbot added a comment.Mar 31 2019, 4:25 PM

Change 500237 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@wmf/1.33.0-wmf.23] Fix GrammaticalFeatureListWidget

https://gerrit.wikimedia.org/r/500237

gerritbot added a project: Patch-For-Review.Mar 31 2019, 4:25 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE644f48df8a98: Fix GrammaticalFeatureListWidget.Mar 31 2019, 4:26 PM
Lucas_Werkmeister_WMDE added a comment.Mar 31 2019, 4:27 PM

Backport scheduled for tomorrow’s EU SWAT.

VIGNERON subscribed.Mar 31 2019, 4:41 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Apr 1 2019, 10:11 AM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Apr 1 2019, 11:44 AM

Change 500237 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@wmf/1.33.0-wmf.23] Fix GrammaticalFeatureListWidget

https://gerrit.wikimedia.org/r/500237

Stashbot mentioned this in T219134: `text.trim is not a function` in node selenium tests blocking Wikibase CI; blocking test/merge in WB/WBL/WBMI/etc..Apr 1 2019, 11:57 AM

Mentioned in SAL (#wikimedia-operations) [2019-04-01T11:57:54Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.33.0-wmf.23/extensions/WikibaseLexeme: SWAT: [[gerrit:500237|Fix GrammaticalFeatureListWidget (T219134, T219734)]] (duration: 01m 00s)

Lucas_Werkmeister_WMDE claimed this task.Apr 1 2019, 11:59 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Should be fixed now.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Apr 1 2019, 1:01 PM
Fnielsen added a comment.Apr 1 2019, 4:51 PM

The fix works for me. Thanks!

Fnielsen added a comment.Apr 1 2019, 5:05 PM

currentDay gadget for P813 now in troubles. I wonder if the fix/changes related to this issue.

Mbch331 subscribed.Apr 1 2019, 5:09 PM

It works for me:

afbeelding.png (212×988 px, 8 KB)

I entered P813 in the first field and the date got filled in automatically.

Fnielsen added a comment.Apr 4 2019, 2:49 PM

Yes. This may have been a temporary issue.

Fnielsen closed this task as Resolved.Apr 4 2019, 2:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits