Description
Related Objects
- Mentioned In
- rEWLE644f48df8a98: Fix GrammaticalFeatureListWidget
T219734: Not possible to edit forms of Wikidata lexemes
T219318: Lexeme form grammatical feature editing: backspace on pill reveals '[object Object]'
rEWLE3a980623054b: Fix GrammaticalFeatureListWidget
rEWLEd5482bed07f9: Fix GrammaticalFeatureListWidget
rEWLEed1cad09d147: GrammaticalFeature: ensure pills are shown and have label
rEWLE024a1bb3a0e0: Update code to match new release of OOUI 0.31.1.
rEWLEa62131ece206: Update code to match new release of OOUI 0.31.1. - Mentioned Here
- T219734: Not possible to edit forms of Wikidata lexemes
Event Timeline
Only seems to affect Wikibase as far as I can tell, so no Wikimedia-production-error (Shared Build Failure) yet (not shared). But I think a CI blocker for us is important enough to add to the Campsite board immediately.
This has been added 24 days ago https://github.com/wikimedia/oojs-ui/commit/4bb33dbb85157c30da556b5209c5451084617c9d#diff-84351ce5fc1cd154bd37dd9fe3d15422R155
Then mediawiki/core updated their OOJS dependency https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/6f7d145fdb6c2c2e52fcab10a6c4716cab43a41e
few times actually last two weeks.
I don't have time atm to find a fix, but a possible one is to update tests to use runner/browser that supports trim? might have time for it later today/tomorrow
I had only time to look into one failing test (fails locally too on master)
In GrammaticalFeatureListWidget.test.js two tests fail: I can preset selected values and I can preset selected values with labels.
According to https://github.com/wikimedia/oojs-ui/blob/master/src/widgets/MenuTagMultiselectWidget.js#L233 our tests either miss configuration allowArbitrary: true or we are missing to initialize the select widget menu properly. Though our code GrammaticalFeatureListWidget.js does not initialize with allowArbitrary and that config was *not* introduce recently.
Sorry I didn't have more time to continue on it
Change 499225 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/WikibaseLexeme@master] Update code to match new release of OOUI 0.31.1.
Change 499293 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] GrammaticalFeature: ensure pills are shown and have label
Change 499296 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Fix GrammaticalFeatureListWidget
Change 499225 abandoned by Alaa Sarhan:
Update code to match new release of OOUI 0.31.1.
Change 499293 abandoned by Pablo Grass (WMDE):
GrammaticalFeature: ensure pills are shown and have label
Reason:
All the goodness went into I9bef208815419a4a12791451d268214b54b4ceaf
We (@alaa_wmde @Jakob_WMDE @Pablo-WMDE) just merged https://gerrit.wikimedia.org/r/499296 (I9bef208815419a4a12791451d268214b54b4ceaf) which should fix this.
Change 499296 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix GrammaticalFeatureListWidget
Change 500237 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@wmf/1.33.0-wmf.23] Fix GrammaticalFeatureListWidget
Change 500237 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@wmf/1.33.0-wmf.23] Fix GrammaticalFeatureListWidget
Mentioned in SAL (#wikimedia-operations) [2019-04-01T11:57:54Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.33.0-wmf.23/extensions/WikibaseLexeme: SWAT: [[gerrit:500237|Fix GrammaticalFeatureListWidget (T219134, T219734)]] (duration: 01m 00s)