- Mentioned In
- rEWLE644f48df8a98: Fix GrammaticalFeatureListWidget
T219734: Not possible to edit forms of Wikidata lexemes
T219318: Lexeme form grammatical feature editing: backspace on pill reveals '[object Object]'
rEWLE3a980623054b: Fix GrammaticalFeatureListWidget
rEWLEd5482bed07f9: Fix GrammaticalFeatureListWidget
rEWLEed1cad09d147: GrammaticalFeature: ensure pills are shown and have label
rEWLE024a1bb3a0e0: Update code to match new release of OOUI 0.31.1.
rEWLEa62131ece206: Update code to match new release of OOUI 0.31.1.
- Mentioned Here
- T219734: Not possible to edit forms of Wikidata lexemes
This has been added 24 days ago https://github.com/wikimedia/oojs-ui/commit/4bb33dbb85157c30da556b5209c5451084617c9d#diff-84351ce5fc1cd154bd37dd9fe3d15422R155
Then mediawiki/core updated their OOJS dependency https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/6f7d145fdb6c2c2e52fcab10a6c4716cab43a41e
few times actually last two weeks.
I don't have time atm to find a fix, but a possible one is to update tests to use runner/browser that supports trim? might have time for it later today/tomorrow
I had only time to look into one failing test (fails locally too on master)
In GrammaticalFeatureListWidget.test.js two tests fail: I can preset selected values and I can preset selected values with labels.
According to https://github.com/wikimedia/oojs-ui/blob/master/src/widgets/MenuTagMultiselectWidget.js#L233 our tests either miss configuration allowArbitrary: true or we are missing to initialize the select widget menu properly. Though our code GrammaticalFeatureListWidget.js does not initialize with allowArbitrary and that config was *not* introduce recently.
Sorry I didn't have more time to continue on it