Page MenuHomePhabricator
Create Task
Maniphest T219134

`text.trim is not a function` in node selenium tests blocking Wikibase CI; blocking test/merge in WB/WBL/WBMI/etc.
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

See:
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/41416/console
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/41413/console

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseLexemewmf/1.33.0-wmf.23+8 -4Fix GrammaticalFeatureListWidget
mediawiki/extensions/WikibaseLexememaster+8 -4Fix GrammaticalFeatureListWidget
mediawiki/extensions/WikibaseLexememaster+10 -4GrammaticalFeature: ensure pills are shown and have label
mediawiki/extensions/WikibaseLexememaster+6 -4Update code to match new release of OOUI 0.31.1.
Customize query in gerrit

Related Objects

Event Timeline

Jakob_WMDE created this task.Mar 25 2019, 11:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2019, 11:27 AM
Lucas_Werkmeister_WMDE triaged this task as High priority.Mar 25 2019, 1:02 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).

Only seems to affect Wikibase as far as I can tell, so no ci-test-error yet (not shared). But I think a CI blocker for us is important enough to add to the Campsite board immediately.

• alaa_wmde added a subscriber: • alaa_wmde.Mar 25 2019, 1:28 PM

This has been added 24 days ago https://github.com/wikimedia/oojs-ui/commit/4bb33dbb85157c30da556b5209c5451084617c9d#diff-84351ce5fc1cd154bd37dd9fe3d15422R155

Then mediawiki/core updated their OOJS dependency https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/6f7d145fdb6c2c2e52fcab10a6c4716cab43a41e
few times actually last two weeks.

I don't have time atm to find a fix, but a possible one is to update tests to use runner/browser that supports trim? might have time for it later today/tomorrow

• alaa_wmde claimed this task.Mar 25 2019, 3:24 PM
• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
• alaa_wmde added a subscriber: Lucas_Werkmeister_WMDE.
Addshore moved this task from incoming to in progress on the Wikidata board.Mar 25 2019, 4:00 PM
• alaa_wmde moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Mar 25 2019, 4:18 PM
• alaa_wmde added a comment.Mar 25 2019, 4:24 PM

I had only time to look into one failing test (fails locally too on master)

In GrammaticalFeatureListWidget.test.js two tests fail: I can preset selected values and I can preset selected values with labels.

According to https://github.com/wikimedia/oojs-ui/blob/master/src/widgets/MenuTagMultiselectWidget.js#L233 our tests either miss configuration allowArbitrary: true or we are missing to initialize the select widget menu properly. Though our code GrammaticalFeatureListWidget.js does not initialize with allowArbitrary and that config was *not* introduce recently.

Sorry I didn't have more time to continue on it

Jdforrester-WMF merged a task: T219232: jquery.wikibase.grammaticalfeatureview from WikibaseLexeme is failing, blocking merge in WikibaseMediaInfo (and others?).Mar 25 2019, 9:57 PM
Jdforrester-WMF added projects: Wikimedia-production-error (ARCHIVED -- Shared Build Failure), WikibaseMediaInfo, Wikidata Lexicographical data.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.
Jdforrester-WMF renamed this task from `text.trim is not a function` in node selenium tests blocking Wikibase CI to `text.trim is not a function` in node selenium tests blocking Wikibase CI; blocking test/merge in WB/WBL/WBMI/etc..Mar 25 2019, 10:34 PM
• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Mar 26 2019, 10:26 AM
Lucas_Werkmeister_WMDE raised the priority of this task from High to Unbreak Now!.Mar 26 2019, 11:06 AM

shared CI blockers are UBN

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMar 26 2019, 11:06 AM
gerritbot added a comment.Mar 26 2019, 3:21 PM

Change 499225 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/WikibaseLexeme@master] Update code to match new release of OOUI 0.31.1.

https://gerrit.wikimedia.org/r/499225

gerritbot added a project: Patch-For-Review.Mar 26 2019, 3:21 PM
Addshore moved this task from Untriaged to In progress on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.Mar 26 2019, 3:36 PM
• alaa_wmde mentioned this in rEWLEa62131ece206: Update code to match new release of OOUI 0.31.1..Mar 26 2019, 3:55 PM
• alaa_wmde mentioned this in rEWLE024a1bb3a0e0: Update code to match new release of OOUI 0.31.1..
gerritbot added a comment.Mar 26 2019, 6:28 PM

Change 499293 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] GrammaticalFeature: ensure pills are shown and have label

https://gerrit.wikimedia.org/r/499293

Pablo-WMDE mentioned this in rEWLEed1cad09d147: GrammaticalFeature: ensure pills are shown and have label.Mar 26 2019, 6:30 PM
gerritbot added a comment.Mar 26 2019, 6:48 PM

Change 499296 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Fix GrammaticalFeatureListWidget

https://gerrit.wikimedia.org/r/499296

gerritbot added a comment.Mar 26 2019, 6:49 PM

Change 499225 abandoned by Alaa Sarhan:
Update code to match new release of OOUI 0.31.1.

https://gerrit.wikimedia.org/r/499225

gerritbot added a comment.Mar 26 2019, 6:50 PM

Change 499293 abandoned by Pablo Grass (WMDE):
GrammaticalFeature: ensure pills are shown and have label

Reason:
All the goodness went into I9bef208815419a4a12791451d268214b54b4ceaf

https://gerrit.wikimedia.org/r/499293

Jakob_WMDE mentioned this in rEWLEd5482bed07f9: Fix GrammaticalFeatureListWidget.Mar 26 2019, 6:51 PM
Jakob_WMDE mentioned this in rEWLE3a980623054b: Fix GrammaticalFeatureListWidget.Mar 26 2019, 7:00 PM
Pablo-WMDE added a subscriber: Pablo-WMDE.Mar 26 2019, 7:30 PM

We (@alaa_wmde @Jakob_WMDE @Pablo-WMDE) just merged https://gerrit.wikimedia.org/r/499296 (I9bef208815419a4a12791451d268214b54b4ceaf) which should fix this.

Pablo-WMDE mentioned this in T219318: Lexeme form grammatical feature editing: backspace on pill reveals '[object Object]'.Mar 26 2019, 7:41 PM
gerritbot added a comment.Mar 26 2019, 7:46 PM

Change 499296 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix GrammaticalFeatureListWidget

https://gerrit.wikimedia.org/r/499296

Jdforrester-WMF added a comment.Mar 26 2019, 7:53 PM

Thank you!

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 26 2019, 8:00 PM
sarhan.alaa awarded a token.Mar 26 2019, 9:24 PM
Jdforrester-WMF closed this task as Resolved.Mar 26 2019, 10:55 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF moved this task from In progress to Resolved on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.
Lucas_Werkmeister_WMDE mentioned this in T219734: Not possible to edit forms of Wikidata lexemes.Mar 31 2019, 4:24 PM
gerritbot added a comment.Mar 31 2019, 4:25 PM

Change 500237 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@wmf/1.33.0-wmf.23] Fix GrammaticalFeatureListWidget

https://gerrit.wikimedia.org/r/500237

gerritbot added a project: Patch-For-Review.Mar 31 2019, 4:25 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE644f48df8a98: Fix GrammaticalFeatureListWidget.Mar 31 2019, 4:26 PM
gerritbot added a comment.Apr 1 2019, 11:44 AM

Change 500237 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@wmf/1.33.0-wmf.23] Fix GrammaticalFeatureListWidget

https://gerrit.wikimedia.org/r/500237

Stashbot added a comment.Apr 1 2019, 11:57 AM

Mentioned in SAL (#wikimedia-operations) [2019-04-01T11:57:54Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.33.0-wmf.23/extensions/WikibaseLexeme: SWAT: [[gerrit:500237|Fix GrammaticalFeatureListWidget (T219134, T219734)]] (duration: 01m 00s)

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL