Page MenuHomePhabricator
Create Task
Maniphest T219986

Shortened URLs won't redirect when there's data
Closed, ResolvedPublic
Actions

Description

Right now, https://w.wiki/6 redirects to the right place but https://w.wiki/6?foo gives 404, this makes sharing links in facebook impossible.

Details

SubjectRepoBranchLines +/-
Shortener: add back charset validationoperations/puppetproduction+7 -0
Shortener VCL fixupsoperations/puppetproduction+6 -3
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Apr 3 2019, 12:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2019, 12:52 PM
Ladsgroup added a project: Traffic.Apr 3 2019, 12:56 PM
Ladsgroup added subscribers: BBlack, • ema.

I think there's something with https://github.com/wikimedia/puppet/blob/production/modules/varnish/templates/text-backend.inc.vcl.erb but my knowledge in that regard is so basic that I would probably make a mess

Restricted Application added a project: SRE. · View Herald TranscriptApr 3 2019, 12:56 PM
Pigsonthewing subscribed.Apr 3 2019, 5:49 PM
gerritbot added a comment.Apr 3 2019, 7:16 PM

Change 501032 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] varnish: allow short urls that have query

https://gerrit.wikimedia.org/r/501032

gerritbot added a project: Patch-For-Review.Apr 3 2019, 7:16 PM
• ema triaged this task as Medium priority.Apr 8 2019, 11:36 AM
gerritbot added a comment.Apr 8 2019, 2:52 PM

Change 501032 merged by BBlack:
[operations/puppet@production] Shortener VCL fixups

https://gerrit.wikimedia.org/r/501032

gerritbot added a comment.Apr 8 2019, 3:01 PM

Change 502238 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] Shortener: add back charset validation

https://gerrit.wikimedia.org/r/502238

gerritbot added a comment.Apr 8 2019, 3:02 PM

Change 502238 merged by BBlack:
[operations/puppet@production] Shortener: add back charset validation

https://gerrit.wikimedia.org/r/502238

Legoktm closed this task as Resolved.Apr 14 2019, 8:32 AM
Legoktm assigned this task to Ladsgroup.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptApr 14 2019, 8:32 AM
Lucas_Werkmeister_WMDE mentioned this in T219968: Enable the URLshortener for WDQS.Apr 15 2019, 11:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL