Maniphest T220136

Negative numbers are not being rounded on Event Summary page data display
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• jmatazzoni
	Apr 4 2019, 5:59 PM

Description

When the Bytes Changed numbers show negative contributions, the numbers aren't being rounded in the way all other numbers on the page are. See screenshot. Please apply rounding to negatives as well.

Testing

Here's a test event in "joe's testing events" with total Negative Contributions

Screen Shot 2019-04-04 at 10.50.53 AM.png (849×1 px, 145 KB)

Related Objects

Mentioned In: rGEVMbf20b145d288: Support negative abbreviate numbers

Event Timeline

• jmatazzoni created this task.Apr 4 2019, 5:59 PM

• jmatazzoni updated the task description. (Show Details)Apr 4 2019, 6:02 PM

• jmatazzoni updated the task description. (Show Details)

MaxSem claimed this task.Apr 4 2019, 8:58 PM

MaxSem moved this task from Ready to In Development on the Community-Tech-Sprint board.

Ready for review: https://github.com/wikimedia/eventmetrics/pull/277

MaxSem mentioned this in rGEVMbf20b145d288: Support negative abbreviate numbers.Apr 4 2019, 9:14 PM

Merged.

• aezell moved this task from Needs Review/Feedback to Product sign-off on the Community-Tech-Sprint board.Apr 4 2019, 11:08 PM

I tested this just on the one Negative Contributions event I created. The negative number looks good there, so I'm going to assume we're good. Thanks Max. I'll keep an eye out to see if we see this happening again.

• jmatazzoni moved this task from New & TBD Tickets to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.Apr 5 2019, 12:14 AM

• jmatazzoni moved this task from Backlog to In Sprint on the Event Metrics board.

	F28581349: Screen Shot 2019-04-04 at 10.50.53 AM.png
	Apr 4 2019, 5:59 PM

Negative numbers are not being rounded on Event Summary page data displayClosed, ResolvedPublicBUG REPORTActions

Description

Related Objects

Event Timeline

Negative numbers are not being rounded on Event Summary page data display
Closed, ResolvedPublicBUG REPORT
Actions