Maniphest T220204

Make pushPending optional on OO.ui.mixin.RequestManager / OO.ui.mixin.LookupElement widgets
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Apr 5 2019, 1:29 PM

Description

If a lookup suggestions are required to use a widget, it makes sense to show pending while the list is being populated asynchronously, but the suggestions are purely assistive, such as for autocomplete, then having the pending animation show on every keystroke may be unnecessary, especially if the request manager has stopped making useful suggestions (e.g. you have typed enough unique text that there are no longer any matching autocomplete suggestions).

Details

	Subject	Repo	Branch	Lines +/-
	RequestManager: Add showPendingRequest option	oojs/ui	master	+7 -3
	Update OOUI to v0.31.4	mediawiki/core	master	+523 -129

Customize query in gerrit

Related Objects

Mentioned In: T222329: Special:Search generates "TypeError: this.pushPending is not a function"
T50274: VisualEditor: For edit summary field, give users an auto-fill drop-down (or similar) of recent edit summaries they've used

Event Timeline

Esanders created this task.Apr 5 2019, 1:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2019, 1:29 PM

Change 501571 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] RequestManager: Add showPendingRequest option

https://gerrit.wikimedia.org/r/501571

gerritbot added a project: Patch-For-Review.Apr 5 2019, 1:42 PM

Change 501571 merged by jenkins-bot:
[oojs/ui@master] RequestManager: Add showPendingRequest option

https://gerrit.wikimedia.org/r/501571

Volker_E closed this task as Resolved.Apr 7 2019, 2:36 AM

Volker_E assigned this task to Esanders.

Volker_E triaged this task as Medium priority.

Volker_E moved this task from Backlog to OOUI-0.31.4 on the OOUI board.

Volker_E edited projects, added OOUI (OOUI-0.31.4); removed OOUI.

Volker_E removed a project: Patch-For-Review.

Change 504473 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.31.4

https://gerrit.wikimedia.org/r/504473

gerritbot added a project: Patch-For-Review.Apr 16 2019, 11:23 PM

Change 504473 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.31.4

https://gerrit.wikimedia.org/r/504473

Izno mentioned this in T50274: VisualEditor: For edit summary field, give users an auto-fill drop-down (or similar) of recent edit summaries they've used.Apr 25 2019, 1:39 AM

Volker_E mentioned this in T222329: Special:Search generates "TypeError: this.pushPending is not a function".May 2 2019, 3:46 PM

Volker_E removed a project: Patch-For-Review.May 7 2019, 4:08 PM

Change 512227 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWEditSummaryWidget: Remove a hack for T220204

https://gerrit.wikimedia.org/r/512227

gerritbot added a project: Patch-For-Review.May 23 2019, 7:32 PM

Change 512227 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWEditSummaryWidget: Remove a hack for T220204