Maniphest T220533

Special:Block without JavaScript: "Other" field in Expiration section is required even if "Other" is not selected
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Apr 9 2019, 5:00 PM

Description

What is the problem?

To submit the Special:Block form with JavaScript disabled, I am required to type some text into the Other input even if the "Other" expiration option has not been selected.

nojs_other_expiration.png (724×1 px, 41 KB)

It does not seem to matter what you type into this field.

With JS enabled, this input disappears when another option is selected.

Steps to reproduce problem

Disable javascript on the browser
Go to Special:Block (need to be admin)
Attempt to submit a block with an Expiration option other than "Other time:"

Expected behavior: You are not required to type any text into the text input box under "Expiration"
Observed behavior: You are prevented from submitting until you type any text in the input

Details

	Subject	Repo	Branch	Lines +/-
	Allow SelectWithInput to be marked as required and handle that dynamically	mediawiki/core	master	+16 -2

Customize query in gerrit

Related Objects

Mentioned In: T205130: QA the no-JS experience of Partial Blocks by filing all defects in Phab

Event Timeline

dom_walden created this task.Apr 9 2019, 5:00 PM

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptApr 9 2019, 5:00 PM

dom_walden mentioned this in T205130: QA the no-JS experience of Partial Blocks by filing all defects in Phab.Apr 9 2019, 5:01 PM

Assuming this is about MediaWiki-User-management when it comes to a related codebase.

Niharika triaged this task as Medium priority.Apr 9 2019, 5:33 PM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.

JJMC89 moved this task from Backlog to User blocking on the MediaWiki-User-management board.Apr 14 2019, 3:55 AM

Niharika set the point value for this task to 2.Apr 18 2019, 6:21 PM

Niharika moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jul 16 2019, 5:14 PM

Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

dbarratt renamed this task from [BUG] Special:Block without JavaScript: "Other" field in Expiration section is required even if "Other" is not selected to Special:Block without JavaScript: "Other" field in Expiration section is required even if "Other" is not selected.Jul 19 2019, 6:49 PM

dbarratt claimed this task.

dbarratt moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 524945 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Allow SelectWithInput to be marked as required and handle that dynamically

https://gerrit.wikimedia.org/r/524945

gerritbot added a project: Patch-For-Review.Jul 22 2019, 11:07 PM

dbarratt moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jul 22 2019, 11:08 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Jul 31 2019, 11:09 AM

Change 524945 merged by jenkins-bot:
[mediawiki/core@master] Allow SelectWithInput to be marked as required and handle that dynamically

https://gerrit.wikimedia.org/r/524945

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Jul 31 2019, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2019, 2:11 PM

Without JS, it is not longer required to enter a value into the "Other" field (unless the "Other" dropdown is selected).

With JS, things behave as before (the "Other" field does not appear unless the "Other" dropdown is selected).

I also briefly tested Special:Block on mobile and IE11 (both with and without JS).

For regression purposes, I tested that there was nothing stopping me submitting a valid block (with and without JS).

Via the API: the error "Expiry time invalid." appears whenever the "expiry" parameter is invalid.

dbarratt closed this task as Resolved.Aug 8 2019, 9:33 PM

Special:Block without JavaScript: "Other" field in Expiration section is required even if "Other" is not selectedClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions