Page MenuHomePhabricator
Create Task
Maniphest T221668

Pasting tables from Google sheets pollutes the document with data-sheets- attributes
Closed, ResolvedPublic
Actions

Description

e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Echo_test_page_265234767519492336280204205579743813910&type=revision&diff=392169&oldid=370919&diffmode=source

Details

SubjectRepoBranchLines +/-
Restore external paste sanitization of DOM elementsmediawiki/extensions/VisualEditorwmf/1.34.0-wmf.1+2 -0
Restore external paste sanitization of DOM elementsmediawiki/extensions/VisualEditormaster+2 -0
Customize query in gerrit

Event Timeline

Esanders created this task.Apr 23 2019, 4:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2019, 4:31 PM
Esanders added a comment.Apr 23 2019, 6:44 PM

I think this is a regression caused by out paste rules refactor: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/502558/

gerritbot added a comment.Apr 23 2019, 6:49 PM

Change 505865 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Restore external paste sanitization of DOM elements

https://gerrit.wikimedia.org/r/505865

gerritbot added a project: Patch-For-Review.Apr 23 2019, 6:49 PM
Esanders triaged this task as Unbreak Now! priority.Apr 23 2019, 6:51 PM

This is potentially polluting the wikis with lots of unwanted HTML attributes as we accidentally turned of DOM node sanitisation, so we should backport.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptApr 23 2019, 6:51 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Apr 23 2019, 8:02 PM
Esanders moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.
gerritbot added a comment.Apr 23 2019, 10:37 PM

Change 505865 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Restore external paste sanitization of DOM elements

https://gerrit.wikimedia.org/r/505865

gerritbot added a comment.Apr 23 2019, 10:40 PM

Change 506022 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.1] Restore external paste sanitization of DOM elements

https://gerrit.wikimedia.org/r/506022

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 23 2019, 11:00 PM
gerritbot added a comment.Apr 23 2019, 11:15 PM

Change 506022 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.1] Restore external paste sanitization of DOM elements

https://gerrit.wikimedia.org/r/506022

Stashbot added a comment.Apr 23 2019, 11:20 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-23T23:20:18Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.1/extensions/VisualEditor/modules/ve-mw/init/ve.init.mw.Target.js: SWAT T221668 VisualEditor: Restore external paste sanitization of DOM elements (duration: 00m 55s)

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.1; 2019-04-16); removed MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 24 2019, 12:00 AM
Jdforrester-WMF closed this task as Resolved.Apr 30 2019, 9:33 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF subscribed.

This was deployed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL