If the user has the help panel disabled, but the homepage enabled, the help module is still present on the homepage. If the user then clicks the button to open the help panel in a dialog, the UI the user will get is always as if they don't have an email address set, even if they do.
Steps to repro:
- Ensure help panel pref is disabled, homepage enabled
- Ensure that the user has an email address set (whether confirmed or unconfirmed)
- Go to Special:Homepage
- Click the "Ask the help desk" button
Expected: the dialog that opens displays the user's email address, either in a text input (if unconfirmed) or as text (if confirmed).
Actual: the dialog doesn't display the user's email address, it acts as if the user has not set one
I think this is because the config variables used by this code are only exported if the help panel is enabled. They should be exported unconditionally on Special:Homepage as well.