Page MenuHomePhabricator

Help module doesn't behave correctly wrt email when help panel is not enabled
Closed, ResolvedPublic

Description

If the user has the help panel disabled, but the homepage enabled, the help module is still present on the homepage. If the user then clicks the button to open the help panel in a dialog, the UI the user will get is always as if they don't have an email address set, even if they do.

Steps to repro:

  1. Ensure help panel pref is disabled, homepage enabled
  2. Ensure that the user has an email address set (whether confirmed or unconfirmed)
  3. Go to Special:Homepage
  4. Click the "Ask the help desk" button

Expected: the dialog that opens displays the user's email address, either in a text input (if unconfirmed) or as text (if confirmed).
Actual: the dialog doesn't display the user's email address, it acts as if the user has not set one

I think this is because the config variables used by this code are only exported if the help panel is enabled. They should be exported unconditionally on Special:Homepage as well.

Event Timeline

The same case for unconfirmed email - the empty (not pre-populated with the unconfirmed email address) textbox will be displayed in Help module on Homepage if Help panel is disabled in Preferences.

Change 506665 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Add user email vars for Help and Mentorship modules

https://gerrit.wikimedia.org/r/506665

Change 506665 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add user email vars for Help and Mentorship modules

https://gerrit.wikimedia.org/r/506665