Page MenuHomePhabricator
Create Task
Maniphest T222250

[wmf.3 - regression] testwiki - placeholded image for cx-selected-source-page__image not displayed
Closed, ResolvedPublic
Actions

Description

In dewiki (wmf.1) Suggestions on Special:ContentTranslation display a standard thumbnail image when an article does not have an image to display :
<div class="cx-selected-source-page__image oo-ui-iconElement-icon oo-ui-icon-page-existing"></div>

Screen Shot 2019-04-30 at 9.12.10 PM.png (722×915 px, 102 KB)

In testwiki (wmf.3) - the placeholder thumbnail image is missing:
Note: the issue is present for other languages too.

Screen Shot 2019-04-30 at 9.12.25 PM.png (709×928 px, 91 KB)

Details

SubjectRepoBranchLines +/-
Fix article placeholder imagesmediawiki/extensions/ContentTranslationmaster+3 -7
Fix article images after changes in mw.widgets.TitleOptionWidgetmediawiki/extensions/ContentTranslationmaster+6 -6
Customize query in gerrit

Event Timeline

Etonkovidova created this task.May 1 2019, 4:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2019, 4:25 AM
gerritbot added a comment.May 1 2019, 8:01 AM

Change 507511 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix article images after changes in mw.widgets.TitleOptionWidget

https://gerrit.wikimedia.org/r/507511

gerritbot added a project: Patch-For-Review.May 1 2019, 8:01 AM
• Petar.petkovic claimed this task.May 1 2019, 8:02 AM
• Petar.petkovic added a project: Language-Team (Language-2019-April-June).
• Petar.petkovic moved this task from Backlog to In Review on the Language-Team (Language-2019-April-June) board.
Esanders subscribed.May 1 2019, 10:30 AM

Extending TitleOptionWidget here would help...

• Petar.petkovic added a comment.May 1 2019, 10:32 AM
In T222250#5149601, @Esanders wrote:

Extending TitleOptionWidget here would help...

All lists on Content Translation dashboard need OOUI refactoring. List items are not keyboard accessible and regressions like this happen every once in a while.

gerritbot added a comment.May 2 2019, 7:43 AM

Change 507511 merged by Petar.petkovic:
[mediawiki/extensions/ContentTranslation@master] Fix article images after changes in mw.widgets.TitleOptionWidget

https://gerrit.wikimedia.org/r/507511

• Petar.petkovic removed a project: Patch-For-Review.May 2 2019, 7:44 AM
• Petar.petkovic moved this task from In Review to Needs QA on the Language-Team (Language-2019-April-June) board.
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 2 2019, 8:00 AM
gerritbot added a comment.May 2 2019, 9:47 PM

Change 507890 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix article placeholder images

https://gerrit.wikimedia.org/r/507890

gerritbot added a project: Patch-For-Review.May 2 2019, 9:47 PM
• Petar.petkovic moved this task from Needs QA to In Review on the Language-Team (Language-2019-April-June) board.May 2 2019, 9:47 PM
gerritbot added a comment.May 6 2019, 12:01 PM

Change 507890 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix article placeholder images

https://gerrit.wikimedia.org/r/507890

• Petar.petkovic removed a project: Patch-For-Review.May 6 2019, 12:02 PM
• Petar.petkovic moved this task from In Review to Needs QA on the Language-Team (Language-2019-April-June) board.
Etonkovidova closed this task as Resolved.May 7 2019, 8:36 PM
Etonkovidova moved this task from Needs QA to Done on the Language-Team (Language-2019-April-June) board.

Checked in testwiki wmf.4

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL