Page MenuHomePhabricator

Watchlist empty page doesn't have width limitation
Closed, ResolvedPublic

Description

When MobileFrontend is installed a new watchlist page is used when you append ?useformat=mobile to the end of the URI.

On the Watchlist, when there are no results it uses .info and .empty-page class.
It results in text without max-length.

Expected result

  • Limit .empty-page to match the max-width of the header (993.3px)

Developer notes

Although MobileFrontend is needed to replicate this bug, the fix should be added to the relevant skinStyle in Minerva.

Event Timeline

alexhollender moved this task from Needs analysis to Queue on the Readers-Web-Backlog (Design) board.

@Volker_E the header seems to have a max-width of 993.3px. Do you think it would make sense to match that for the body?

@alexhollender Yes, absolutely. With that duplicated values it could also be more easily found if the header size changes…

Ok, I'm moving this out of design. I've taken your point "Evaluate if subtle Base30 color is strong enough for the message" and moved it to T222871, which I've made slightly more broad.

Change 656960 had a related patch set uploaded (by Yash9265; owner: Yash9265):
[mediawiki/extensions/MobileFrontend@master] Watchlist empty page doesn't have width limitation

https://gerrit.wikimedia.org/r/656960

Change 656960 had a related patch set uploaded (by Ammarpad; owner: Yash9265):
[mediawiki/extensions/MobileFrontend@master] Add max-width limit to empty watchlist page

https://gerrit.wikimedia.org/r/656960

@Yash4357 yes. @Ammarpad has left you feedback on the gerrit patch.

Change 657576 had a related patch set uploaded (by Yash9265; owner: Yash9265):
[mediawiki/skins/MinervaNeue@master] Add max-width limit to empty watchlist page

https://gerrit.wikimedia.org/r/657576

Change 656960 abandoned by Yash9265:
[mediawiki/extensions/MobileFrontend@master] Add max-width limit to empty watchlist page

Reason:
Made fresh patch in MinervaNeue repository as suggested by Jdlrobson

https://gerrit.wikimedia.org/r/656960

Change 657576 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Add max-width limit to empty watchlist page

https://gerrit.wikimedia.org/r/657576

Edtadros added a subscriber: Edtadros.

Test Result - Beta

Status: ❓ Need More Info
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

When MobileFrontend is installed a new watchlist page is used when you append ?useformat=mobile to the end of the URI.

On the Watchlist, when there are no results it uses .info and .empty-page class.
It results in text without max-length.

Expected result
❓ AC1: Limit .empty-page to match the max-width of the header (993.3px)

@Jdlrobson, the content does appear to be close to the width of the header. The content is 995.3px for the content vs 99.5 for the header. Both values are different than the expected result. Is this acceptable?

This looks like a pass to me, but @alexhollender should confirm and move to QA in prod if so.

ovasileva claimed this task.