Remove feature flag for the bugfix for wbeditentity setting aliases to empty array
Closed, ResolvedPublic
Actions

Description

This bugfix was added with a feature flag. After it has deployed on production with T223303: on production enable bugfix for wbeditentity setting aliases to empty array, this feature flag can be removed.

acceptance criteria

feature flag is no longer present in production code
feature flag is no longer present in tests
feature flag is no longer present in config (Wikibase.php, InitialiseSettings.php, InitialiseSettings-labs.php)

Details

	Subject	Repo	Branch	Lines +/-
	Remove feature flag for the bugfix for wbeditentity setting aliases to empty array	mediawiki/extensions/Wikibase	master	+3 -41

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• alaa_wmde	T203337 Fix wbeditentity API ignoring setting aliases to an empty set
		Resolved		Rosalie_WMDE	T223305 Remove feature flag for the bugfix for wbeditentity setting aliases to empty array

Event Timeline

Michael created this task.May 14 2019, 5:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2019, 5:08 PM

Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:28 PM

Rosalie_WMDE claimed this task.Jun 26 2019, 10:56 AM

Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Rosalie_WMDE subscribed.

Change 519224 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove feature flag for the bugfix for wbeditentity setting aliases to empty array

https://gerrit.wikimedia.org/r/519224

gerritbot added a project: Patch-For-Review.Jun 26 2019, 1:17 PM

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 26 2019, 1:52 PM

Change 519224 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove feature flag for the bugfix for wbeditentity setting aliases to empty array

https://gerrit.wikimedia.org/r/519224

Rosalie_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 26 2019, 2:41 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2019, 3:10 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jun 26 2019, 7:02 PM

Rosalie_WMDE moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 3 2019, 7:56 AM

Rosalie_WMDE moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 3 2019, 8:45 AM

• alaa_wmde moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 5 2019, 1:41 PM

• alaa_wmde closed this task as Resolved.Jul 5 2019, 1:44 PM