[Beta Commons] Attempting to add qualifiers when logged out repeatedly triggers IP address log warning
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• Ramsey-WMF
	May 14 2019, 7:29 PM

Description

User story: N/A

We have this:

We want this:
IP address logging warning is shown only once (on the first attempt to edit)

Screenshots (if possible):
See above

Acceptance Criteria:

Can be tested on e.g. https://commons.wikimedia.beta.wmflabs.org/wiki/File:Photo_on_08-02-2019_at_16.35.jpg

IP address logging warning is shown only once (on the first attempt to edit)

QA Results

AC	Status	Details
1	✅	T223321#5208067

Details

	Subject	Repo	Branch	Lines +/-
	Show anon warning only once	mediawiki/extensions/WikibaseMediaInfo	master	+43 -42

Customize query in gerrit

Event Timeline

• Ramsey-WMF created this task.May 14 2019, 7:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2019, 7:29 PM

• Ramsey-WMF assigned this task to matthiasmullie.May 14 2019, 7:30 PM

• Ramsey-WMF triaged this task as High priority.May 14 2019, 7:37 PM

• Ramsey-WMF edited projects, added SDC-Statements (Depicts-on-training-wheels); removed SDC-Statements (Depicts-Walking).

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

"first attempt to edit", is this:

every time one goes into edit mode, not for any other change after that
only when user goes into edit mode for the first time for this statement
only when user goes into edit mode for the first time for any statement (= if this was already displayed for another statement, we're not showing it again)
only ever once, for statements OR captions, for whichever is first (making changes to captions, statements, captions again, ... = still only one notification for the very first change, and none after)

(all options are pretty straightforward)

I'm leaning towards the last two options, and @Ramsey-WMF would like to go for the last option. I'm concurring.

Change 511638 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Show anon warning only once

https://gerrit.wikimedia.org/r/511638

gerritbot added a project: Patch-For-Review.May 21 2019, 7:45 AM

matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.May 21 2019, 7:45 AM

Change 511638 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Show anon warning only once

https://gerrit.wikimedia.org/r/511638

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 21 2019, 11:00 AM

matthiasmullie reassigned this task from matthiasmullie to Edtadros.May 21 2019, 11:17 AM

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.

matthiasmullie updated the task description. (Show Details)

matthiasmullie subscribed.

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:11 PM