Catch exceptions from mw.hook handlers
Closed, ResolvedPublic
Actions

Description

When a hook throws an exception all other subscribers of the hook get also stopped.

Examples

mw.hook( 'wikipage.content' ).add( function ( $content ) {
	throw new Error( 'Foo' );
} );

blocks all extensions and gadgets that also use the hook 'wikipage.content'.

The reason for T220308 was an exception in Maps (Kartographer) that blocked MediaWiki-extensions-TocTree.

Expected behavior

An exception in a subscriber of a hook should not prevent that other subscribers of the hook gets fired.

Details

Subject	Repo	Branch	Lines +/-
mediawiki.base: Convert mw.hook from jQuery.Callbacks() to own code	mediawiki/core	master	+40 -21
mediawiki.base: Add unit tests to mw.hooks	mediawiki/core	master	+63 -0
mediawiki.base: Catch exceptions between mw.hook() handlers	mediawiki/core	master	+42 -3
mediawiki.base: Clean up mw.hook unit tests	mediawiki/core	master	+79 -75

Customize query in gerrit

Related Objects

Mentioned Here: T220308: Use $() instead of mw.hook( 'wikipage.content' ).add() in ext.toctree.js

Event Timeline

Fomafix created this task.May 15 2019, 5:08 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2019, 5:08 AM

Reedy edited projects, added MediaWiki-ResourceLoader; removed MediaWiki-General.May 15 2019, 2:02 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptMay 15 2019, 2:02 PM

Krinkle renamed this task from Catch exceptions on mw.hook to Catch exceptions from mw.hook handlers.May 20 2019, 6:52 PM

Krinkle triaged this task as Low priority.

Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.

Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.

Krinkle added a project: patch-welcome.

Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.Jun 6 2019, 10:45 AM

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.

Hey @Fomafix ! Does we have to use $() instead of mw.hook()...??

Change 674728 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] mediawiki.base: Clean up mw.hook unit tests

https://gerrit.wikimedia.org/r/674728

Change 674730 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] mediawiki.base: Convert mw.hook from jQuery.Callbacks() to own code

https://gerrit.wikimedia.org/r/674730

Change 674731 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] mediawiki.base: Catch exceptions between mw.hook() handlers

https://gerrit.wikimedia.org/r/674731

Krinkle edited projects, added Performance-Team; removed Performance-Team (Radar), patch-welcome.Mar 24 2021, 11:43 PM

Krinkle moved this task from Backlog: Maintenance, non-prioritized to Abstract Wikipedia matrixing on the Performance-Team board.

Change 678810 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/core@master] mediawiki.base: Add unit tests to mw.hooks

https://gerrit.wikimedia.org/r/678810

Krinkle claimed this task.Apr 25 2021, 7:35 PM

Krinkle moved this task from Abstract Wikipedia matrixing to Backlog: Maintenance, non-prioritized on the Performance-Team board.

Change 674728 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.base: Clean up mw.hook unit tests

https://gerrit.wikimedia.org/r/674728

Change 674730 merged by jenkins-bot: