Page MenuHomePhabricator

Wikidata icon doesn't align with property link in statements widget when secondary statement label is present
Closed, ResolvedPublicBUG REPORT


Steps to Reproduce:

When a Statement widget has a secondary label beneath the heading property name (like "depicts" beneath "Items portrayed in this file") and the property in question comes from a remote source (through federation), the Wikidata icon which appears next to the property link is mis-aligned. Here is an example:

Screen Shot 2019-05-17 at 11.29.43 AM.png (680×1 px, 94 KB)

Actual Results:

The icon is aligned to the center of the heading div, which is now 2 lines tall.

Expected Results:

The icon should be aligned to the top so it remains level with the property link, even if additional text appears beneath the panel heading.

I think this is a pretty simple CSS tweak but wanted to create a ticket here before submitting a patch.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 510960 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/WikibaseMediaInfo@master] Ensure wikidata icon remains aligned with property link

Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.
Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.

Change 510960 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Ensure wikidata icon remains aligned with property link

Ramsey-WMF added a subscriber: Ramsey-WMF.

Fixed on production.