Page MenuHomePhabricator

Patch author and owner swapped in gerritbot comments
Open, Needs TriagePublic

Description

E.g. see T223738#5209107.

Change 512231 had a related patch set uploaded (by EBernhardson; owner: DCausse):

While commit has:

Author David Causse
Committer EBernhardson

That is a cherry pick from master that has been done by Ebernerhardson, once why he is listed in the by part. One can see it as the performer. The patch author was DCausse and is thus listed as the owner.


The patch on master https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/511455/2 had an edit:

Change 511455 had a related patch set uploaded (by Jforrester; owner: DCausse)

Author: David Causse
Committer: Jforrester

In that case its correct.

Event Timeline

Pikne created this task.May 24 2019, 7:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2019, 7:05 AM
hashar updated the task description. (Show Details)May 24 2019, 11:07 AM
hashar added a subscriber: hashar.

I am not sure who maintains Gerrit bot, it seems it always use the commit author as the owner and the committer field for the by action. That does not match the reality though :]

Im currently the maintainer of GerritBot source code (its-phabricator) the template your seeing is https://github.com/wikimedia/puppet/blob/production/modules/gerrit/files/homedir/review_site/etc/its/templates/PatchSetCreated.soy

Pikne added a comment.May 24 2019, 1:52 PM

Commit also has "owner" field and I noted that gerritbot provides different owner in this comment.

If gerritbot can read author and committer field and "owner" is taken from author field, then I suppose it would be less confusing and sufficient if in this template "owner" was changed to "author".