Page MenuHomePhabricator
Create Task
Maniphest T223738

PHP Fatal Error on Special:Search with certain offset query parameter
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request URL: GET w/index.php?title=Special:Search&…
Request ID: XOAvYQpAMFkAADX7ytUAAAAR

message
PHP Fatal Error: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult() must be an instance of Elastica\ResultSet, null given
trace
#0 /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php(90): NO_FUNCTION_GIVEN()
#1 /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Searcher.php(354): CirrusSearch\Search\MSearchResponses->transformAsResultSet(CirrusSearch\Search\FullTextResultsType, string)
#2 /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Searcher.php(176): CirrusSearch\Searcher->searchTextInternal(string)
#3 /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/CirrusSearch.php(215): CirrusSearch\Searcher->search(CirrusSearch\Search\SearchQuery)
#4 /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/CirrusSearch.php(188): CirrusSearch->searchTextReal(CirrusSearch\Search\SearchQuery)
#5 /srv/mediawiki/php-1.34.0-wmf.5/includes/search/SearchEngine.php(83): CirrusSearch->doSearchText(string)
#6 /srv/mediawiki/php-1.34.0-wmf.5/includes/search/SearchEngine.php(169): Closure$SearchEngine::searchText()
#7 /srv/mediawiki/php-1.34.0-wmf.5/includes/search/SearchEngine.php(84): SearchEngine->maybePaginate(Closure$SearchEngine::searchText;3546)
#8 /srv/mediawiki/php-1.34.0-wmf.5/includes/specials/SpecialSearch.php(341): SearchEngine->searchText(string)
#9 /srv/mediawiki/php-1.34.0-wmf.5/includes/specials/SpecialSearch.php(173): SpecialSearch->showResults(string)
#10 /srv/mediawiki/php-1.34.0-wmf.5/includes/specialpage/SpecialPage.php(570): SpecialSearch->execute(NULL)
#11 /srv/mediawiki/php-1.34.0-wmf.5/includes/specialpage/SpecialPageFactory.php(575): SpecialPage->run(NULL)
#12 /srv/mediawiki/php-1.34.0-wmf.5/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#13 /srv/mediawiki/php-1.34.0-wmf.5/includes/MediaWiki.php(865): MediaWiki->performRequest()
#14 /srv/mediawiki/php-1.34.0-wmf.5/includes/MediaWiki.php(515): MediaWiki->main()
#15 /srv/mediawiki/php-1.34.0-wmf.5/index.php(42): MediaWiki->run()
#16 /srv/mediawiki/w/index.php(3): include(string)

Impact

This is a fatal error with HTTP 500 response (non-cacheable) triggered from a public URL.

Notes

I've reduced one of the failure cases to the following:

https://en.wikipedia.org/w/index.php?title=Special:Search&offset=30000&search=www

It is a regression in the branch since this week (php-1.34.0-wmf.5). The error had no prior occurrences in Logstash.

Screenshot 2019-05-18 at 18.23.01.png (492×2 px, 98 KB)

Details

SubjectRepoBranchLines +/-
Consider searching out of limits an errormediawiki/extensions/CirrusSearchwmf/1.34.0-wmf.6+3 -27
Consider searching out of limits an errormediawiki/extensions/CirrusSearchmaster+3 -27
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.May 18 2019, 4:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2019, 4:19 PM
Krinkle triaged this task as High priority.May 18 2019, 4:21 PM
Krinkle updated the task description. (Show Details)
Krinkle moved this task from Untriaged to May 2019 / 1.34.wmf.5+ on the Wikimedia-production-error board.

Tentatively setting High priority because the error in question is a fatal, happens regularly, and there's high confidence it was caused by a change that landed this week.

• dcausse claimed this task.May 22 2019, 7:12 AM
• dcausse moved this task from needs triage to Current work on the Discovery-Search board.
• dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
• dcausse moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.
• dcausse merged a task: T223912: PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult()....
• dcausse subscribed.
• dcausse mentioned this in T223722: PHP Notice: Undefined index: __main__ from MSearchResponses.php.May 23 2019, 5:44 PM
• dcausse merged a task: T223722: PHP Notice: Undefined index: __main__ from MSearchResponses.php.May 23 2019, 5:48 PM
EBernhardson subscribed.EditedMay 23 2019, 6:10 PM

Copying from merged task, this should be fixed by the following patch which ships with this weeks train.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/511455

gerritbot added a comment.May 23 2019, 6:10 PM

Change 511455 had a related patch set uploaded (by Jforrester; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Consider searching out of limits an error

https://gerrit.wikimedia.org/r/511455

gerritbot added a project: Patch-For-Review.May 23 2019, 6:10 PM
gerritbot added a comment.May 23 2019, 7:05 PM

Change 511455 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Consider searching out of limits an error

https://gerrit.wikimedia.org/r/511455

gerritbot added a comment.May 23 2019, 8:23 PM

Change 512231 had a related patch set uploaded (by EBernhardson; owner: DCausse):
[mediawiki/extensions/CirrusSearch@wmf/1.34.0-wmf.6] Consider searching out of limits an error

https://gerrit.wikimedia.org/r/512231

gerritbot added a comment.May 23 2019, 11:38 PM

Change 512231 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@wmf/1.34.0-wmf.6] Consider searching out of limits an error

https://gerrit.wikimedia.org/r/512231

Stashbot added a comment.May 23 2019, 11:43 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-23T23:43:02Z] <ebernhardson@deploy1001> Started scap: php-1.34.0-wmf.6/extensions/CirrusSearch/includes/ T223738 Consider searching out of limits an error

Stashbot added a comment.May 24 2019, 12:04 AM

Mentioned in SAL (#wikimedia-operations) [2019-05-24T00:04:35Z] <ebernhardson@deploy1001> Finished scap: php-1.34.0-wmf.6/extensions/CirrusSearch/includes/ T223738 Consider searching out of limits an error (duration: 21m 32s)

EBernhardson added a comment.May 24 2019, 12:10 AM

Looks fixed: https://en.wikipedia.org/w/index.php?title=Special:Search&limit=20&offset=20000&profile=default&search=kennedy

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.May 24 2019, 12:10 AM
Pikne mentioned this in T224262: Patch author and owner swapped in gerritbot comments.May 24 2019, 7:05 AM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.7; 2019-05-28).May 25 2019, 3:01 AM
Krinkle closed this task as Resolved.May 26 2019, 12:57 PM
Krinkle removed a project: Patch-For-Review.

Confirmed in Logstash. Went from 80-100 per 3 hour block, to 0 on May 25.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits