Page MenuHomePhabricator
Create Task
Maniphest T224522

PHP Fatal Error from ApiTimedText: Argument to WikiPage::factory must Title (WikiPage given)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request URL: /w/api.php requests to Commons, initiated from Wikipedia page views.
Request ID: XO2aVApAEDIAADf9UhoAAAAX

message
[{exception_id}] {exception_url} PHP Fatal Error from line 149 of /srv/mediawiki/php-1.34.0-wmf.6/extensions/TimedMediaHandler/includes/ApiTimedText.php: Argument 1 passed to WikiPage::factory() must be an instance of Title, WikiPage given
trace
#0 /srv/mediawiki/php-1.34.0-wmf.6/extensions/TimedMediaHandler/includes/ApiTimedText.php(149): NO_FUNCTION_GIVEN()
#1 /srv/mediawiki/php-1.34.0-wmf.6/extensions/TimedMediaHandler/includes/ApiTimedText.php(92): ApiTimedText->findTimedText(string, string)
#2 /srv/mediawiki/php-1.34.0-wmf.6/includes/api/ApiMain.php(1593): ApiTimedText->execute()
#3 /srv/mediawiki/php-1.34.0-wmf.6/includes/api/ApiMain.php(531): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.34.0-wmf.6/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.34.0-wmf.6/api.php(87): ApiMain->execute()

Impact

Uncertain. Presumably subtitles unavailable for some or all videos.

Notes

Regression in 1.34-wmf.6. Hit only a few times per hour (100 times today). So either we have only that many plays a day on videos with subtitles enabled, or it's an issue with specific videos only.

Details

SubjectRepoBranchLines +/-
Fix fatal in ApiTimedText following redirect pagesmediawiki/extensions/TimedMediaHandlerwmf/1.34.0-wmf.7+5 -1
Fix fatal in ApiTimedText following redirect pagesmediawiki/extensions/TimedMediaHandlerwmf/1.34.0-wmf.6+5 -1
Fix fatal in ApiTimedText following redirect pagesmediawiki/extensions/TimedMediaHandlermaster+5 -1
Customize query in gerrit

Event Timeline

Krinkle created this task.May 28 2019, 9:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2019, 9:00 PM
Krinkle added a subscriber: • brooke.May 28 2019, 9:00 PM

@brion Ping :)

Krinkle moved this task from Untriaged to Sep2019/1.34.wmf.21+ on the Wikimedia-production-error board.May 28 2019, 9:00 PM
Krinkle updated the task description. (Show Details)
• brooke claimed this task.May 28 2019, 9:01 PM
Krinkle removed • brooke as the assignee of this task.EditedMay 28 2019, 9:01 PM
Krinkle assigned this task to • brooke.
Krinkle updated the task description. (Show Details)

(Sorry, phab conflict.)

• brooke added a comment.May 28 2019, 10:07 PM

Ah I see! Typo, should be $title where it's $page in this:

					$title = $page->getRedirectTarget();
					$page = WikiPage::factory( $page );
gerritbot added a comment.May 28 2019, 10:11 PM

Change 513000 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513000

gerritbot added a project: Patch-For-Review.May 28 2019, 10:11 PM
gerritbot added a comment.May 28 2019, 10:43 PM

Change 513000 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513000

gerritbot added a comment.May 28 2019, 10:44 PM

Change 513010 had a related patch set uploaded (by Jforrester; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.7] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513010

gerritbot added a comment.May 28 2019, 10:44 PM

Change 513011 had a related patch set uploaded (by Jforrester; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.6] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513011

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).May 28 2019, 11:00 PM
gerritbot added a comment.May 28 2019, 11:05 PM

Change 513011 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.6] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513011

gerritbot added a comment.May 28 2019, 11:06 PM

Change 513010 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.7] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513010

Maintenance_bot removed a project: Patch-For-Review.May 28 2019, 11:10 PM
Stashbot added a comment.May 28 2019, 11:14 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-28T23:14:25Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.6/extensions/TimedMediaHandler/includes/ApiTimedText.php: T224522 Fix fatal in ApiTimedText following redirect pages (duration: 00m 58s)

Jdforrester-WMF closed this task as Resolved.May 28 2019, 11:17 PM
Jdforrester-WMF edited projects, added MW-1.34-notes (1.34.0-wmf.6; 2019-05-21); removed MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).
Jdforrester-WMF subscribed.

Backported.

Stashbot added a comment.May 28 2019, 11:19 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-28T23:19:10Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.7/extensions/TimedMediaHandler/includes/ApiTimedText.php: T224522 Fix fatal in ApiTimedText following redirect pages (duration: 00m 56s)

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.7; 2019-05-28); removed MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 29 2019, 12:00 AM
Krinkle moved this task from Sep2019/1.34.wmf.21+ to Resolved on the Wikimedia-production-error board.May 29 2019, 4:27 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits