Page MenuHomePhabricator

PHP Fatal Error from ApiTimedText: Argument to WikiPage::factory must Title (WikiPage given)
Closed, ResolvedPublic

Description

Error

Request URL: /w/api.php requests to Commons, initiated from Wikipedia page views.
Request ID: XO2aVApAEDIAADf9UhoAAAAX

message
[{exception_id}] {exception_url} PHP Fatal Error from line 149 of /srv/mediawiki/php-1.34.0-wmf.6/extensions/TimedMediaHandler/includes/ApiTimedText.php: Argument 1 passed to WikiPage::factory() must be an instance of Title, WikiPage given
trace
#0 /srv/mediawiki/php-1.34.0-wmf.6/extensions/TimedMediaHandler/includes/ApiTimedText.php(149): NO_FUNCTION_GIVEN()
#1 /srv/mediawiki/php-1.34.0-wmf.6/extensions/TimedMediaHandler/includes/ApiTimedText.php(92): ApiTimedText->findTimedText(string, string)
#2 /srv/mediawiki/php-1.34.0-wmf.6/includes/api/ApiMain.php(1593): ApiTimedText->execute()
#3 /srv/mediawiki/php-1.34.0-wmf.6/includes/api/ApiMain.php(531): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.34.0-wmf.6/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.34.0-wmf.6/api.php(87): ApiMain->execute()

Impact

Uncertain. Presumably subtitles unavailable for some or all videos.

Notes

Regression in 1.34-wmf.6. Hit only a few times per hour (100 times today). So either we have only that many plays a day on videos with subtitles enabled, or it's an issue with specific videos only.

Event Timeline

Krinkle created this task.May 28 2019, 9:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2019, 9:00 PM
Krinkle updated the task description. (Show Details)
brion claimed this task.May 28 2019, 9:01 PM
Krinkle removed brion as the assignee of this task.EditedMay 28 2019, 9:01 PM
Krinkle assigned this task to brion.
Krinkle updated the task description. (Show Details)

(Sorry, phab conflict.)

Ah I see! Typo, should be $title where it's $page in this:

					$title = $page->getRedirectTarget();
					$page = WikiPage::factory( $page );

Change 513000 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513000

Change 513000 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513000

Change 513010 had a related patch set uploaded (by Jforrester; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.7] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513010

Change 513011 had a related patch set uploaded (by Jforrester; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.6] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513011

Change 513011 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.6] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513011

Change 513010 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.7] Fix fatal in ApiTimedText following redirect pages

https://gerrit.wikimedia.org/r/513010

Mentioned in SAL (#wikimedia-operations) [2019-05-28T23:14:25Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.6/extensions/TimedMediaHandler/includes/ApiTimedText.php: T224522 Fix fatal in ApiTimedText following redirect pages (duration: 00m 58s)

Mentioned in SAL (#wikimedia-operations) [2019-05-28T23:19:10Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.7/extensions/TimedMediaHandler/includes/ApiTimedText.php: T224522 Fix fatal in ApiTimedText following redirect pages (duration: 00m 56s)