Page MenuHomePhabricator

Remove position top/bottom from extensions ResourceModules configuration
Closed, ResolvedPublic0 Story Points

Description

Per @Krinkle in T186363#5213064:

If anyone feels particularly strongly about these ignored additional keys, they are free to remove them from code they maintain at their earliest convenience.

https://codesearch.wmflabs.org/search/?q=%22position%22%3A%20%22(top%7Cbottom)%22&i=nope&files=&repos=

Details

Related Gerrit Patches:
mediawiki/extensions/FlaggedRevs : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/Collection : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/MiniInvite : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/TimedMediaHandler : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/MultiUpload : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/SectionDisqus : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/PictureGame : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/ExtensionDistributor : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/FanBoxes : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/BreadCrumbs : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/ImageMetrics : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/EventLogging : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/skins/Modern : masterRemove unused "position" field from "ResourceModules" in skin.json
mediawiki/skins/Amethyst : masterRemove unused "position" field from "ResourceModules" in skin.json
mediawiki/extensions/MultimediaViewer : masterRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/BlueSpiceSMWConnector : REL1_31_devRemove unused "position" field from "ResourceModules" in extension.json
mediawiki/extensions/BlueSpiceSMWConnector : masterRemove unused "position" field from "ResourceModules" in extension.json

Event Timeline

Legoktm created this task.Jun 3 2019, 1:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2019, 1:50 AM

Change 513927 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BlueSpiceSMWConnector@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513927

Change 513928 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BreadCrumbs@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513928

Change 513929 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Collection@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513929

Change 513930 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/EventLogging@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513930

Change 513931 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ExtensionDistributor@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513931

Change 513932 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/FanBoxes@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513932

Change 513933 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ImageMetrics@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513933

Change 513934 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/MiniInvite@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513934

Change 513935 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/MultiUpload@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513935

Change 513936 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/MultimediaViewer@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513936

Change 513937 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/PictureGame@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513937

Change 513938 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/SectionDisqus@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513938

Change 513939 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/TimedMediaHandler@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513939

Change 513940 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/skins/Amethyst@master] Remove unused "position" field from "ResourceModules" in skin.json

https://gerrit.wikimedia.org/r/513940

Change 513941 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/skins/Modern@master] Remove unused "position" field from "ResourceModules" in skin.json

https://gerrit.wikimedia.org/r/513941

Legoktm updated the task description. (Show Details)Jun 3 2019, 2:20 AM
Legoktm claimed this task.Jun 3 2019, 2:28 AM

Change 513948 had a related patch set uploaded (by Robert Vogel; owner: Legoktm):
[mediawiki/extensions/BlueSpiceSMWConnector@REL1_31_dev] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513948

Change 513927 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceSMWConnector@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513927

Change 513948 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceSMWConnector@REL1_31_dev] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513948

Change 513936 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513936

Change 513940 merged by jenkins-bot:
[mediawiki/skins/Amethyst@master] Remove unused "position" field from "ResourceModules" in skin.json

https://gerrit.wikimedia.org/r/513940

Change 513941 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Remove unused "position" field from "ResourceModules" in skin.json

https://gerrit.wikimedia.org/r/513941

Change 513930 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513930

Change 513933 merged by Jforrester:
[mediawiki/extensions/ImageMetrics@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513933

Change 513928 merged by jenkins-bot:
[mediawiki/extensions/BreadCrumbs@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513928

Change 513931 merged by jenkins-bot:
[mediawiki/extensions/ExtensionDistributor@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513931

Change 513932 merged by jenkins-bot:
[mediawiki/extensions/FanBoxes@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513932

Change 513937 merged by jenkins-bot:
[mediawiki/extensions/PictureGame@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513937

Change 513938 merged by jenkins-bot:
[mediawiki/extensions/SectionDisqus@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513938

Change 513935 merged by jenkins-bot:
[mediawiki/extensions/MultiUpload@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513935

Change 513939 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513939

Change 513934 merged by Jforrester:
[mediawiki/extensions/MiniInvite@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513934

Change 513929 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513929

Change 523842 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/FlaggedRevs@master] Remove unused "position" field from "ResourceModules" in skin.json

https://gerrit.wikimedia.org/r/523842

One repo left!

Change 523842 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/523842

Legoktm closed this task as Resolved.Jul 17 2019, 6:28 PM