Page MenuHomePhabricator
Create Task
Maniphest T224847

Remove position top/bottom from extensions ResourceModules configuration
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Per @Krinkle in T186363#5213064:

If anyone feels particularly strongly about these ignored additional keys, they are free to remove them from code they maintain at their earliest convenience.

https://codesearch.wmflabs.org/search/?q=%22position%22%3A%20%22(top%7Cbottom)%22&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/FlaggedRevsmaster+9 -5
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/Collectionmaster+0 -1
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/MiniInvitemaster+4 -8
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/TimedMediaHandlermaster+42 -19
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/MultiUploadmaster+1 -2
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/SectionDisqusmaster+0 -1
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/PictureGamemaster+21 -19
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/ExtensionDistributormaster+0 -1
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/FanBoxesmaster+9 -7
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/BreadCrumbsmaster+2 -3
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/ImageMetricsmaster+1 -2
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/EventLoggingmaster+11 -8
Remove unused "position" field from "ResourceModules" in skin.jsonmediawiki/skins/Modernmaster+0 -1
Remove unused "position" field from "ResourceModules" in skin.jsonmediawiki/skins/Amethystmaster+1 -3
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/MultimediaViewermaster+1 -2
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/BlueSpiceSMWConnectorREL1_31_dev+1 -2
Remove unused "position" field from "ResourceModules" in extension.jsonmediawiki/extensions/BlueSpiceSMWConnectormaster+1 -2
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Jun 3 2019, 1:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2019, 1:50 AM
gerritbot added a comment.Jun 3 2019, 2:11 AM

Change 513927 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BlueSpiceSMWConnector@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513927

gerritbot added a project: Patch-For-Review.Jun 3 2019, 2:11 AM

Change 513928 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BreadCrumbs@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513928

gerritbot added a comment.Jun 3 2019, 2:11 AM

Change 513929 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Collection@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513929

gerritbot added a comment.Jun 3 2019, 2:11 AM

Change 513930 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/EventLogging@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513930

gerritbot added a comment.Jun 3 2019, 2:11 AM

Change 513931 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ExtensionDistributor@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513931

gerritbot added a comment.Jun 3 2019, 2:12 AM

Change 513932 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/FanBoxes@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513932

gerritbot added a comment.Jun 3 2019, 2:12 AM

Change 513933 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ImageMetrics@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513933

Legoktm mentioned this in rEBSSMWCa93bb4c1e1c3: Remove unused "position" field from "ResourceModules" in extension.json.Jun 3 2019, 2:12 AM
gerritbot added a comment.Jun 3 2019, 2:12 AM

Change 513934 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/MiniInvite@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513934

gerritbot added a comment.Jun 3 2019, 2:12 AM

Change 513935 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/MultiUpload@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513935

gerritbot added a comment.Jun 3 2019, 2:12 AM

Change 513936 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/MultimediaViewer@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513936

gerritbot added a comment.Jun 3 2019, 2:13 AM

Change 513937 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/PictureGame@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513937

gerritbot added a comment.Jun 3 2019, 2:13 AM

Change 513938 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/SectionDisqus@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513938

gerritbot added a comment.Jun 3 2019, 2:13 AM

Change 513939 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/TimedMediaHandler@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513939

gerritbot added a comment.Jun 3 2019, 2:14 AM

Change 513940 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/skins/Amethyst@master] Remove unused "position" field from "ResourceModules" in skin.json

https://gerrit.wikimedia.org/r/513940

gerritbot added a comment.Jun 3 2019, 2:15 AM

Change 513941 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/skins/Modern@master] Remove unused "position" field from "ResourceModules" in skin.json

https://gerrit.wikimedia.org/r/513941

Legoktm updated the task description. (Show Details)Jun 3 2019, 2:20 AM
Legoktm mentioned this in rMSAM6a8141b3ebe8: Remove unused "position" field from "ResourceModules" in skin.json.Jun 3 2019, 2:23 AM
Legoktm claimed this task.Jun 3 2019, 2:28 AM
gerritbot added a comment.Jun 3 2019, 5:57 AM

Change 513948 had a related patch set uploaded (by Robert Vogel; owner: Legoktm):
[mediawiki/extensions/BlueSpiceSMWConnector@REL1_31_dev] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513948

gerritbot added a comment.Jun 3 2019, 5:58 AM

Change 513927 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceSMWConnector@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513927

gerritbot added a comment.Jun 3 2019, 5:58 AM

Change 513948 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceSMWConnector@REL1_31_dev] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513948

Osnard mentioned this in rEBSSMWC63cc89de6877: Remove unused "position" field from "ResourceModules" in extension.json.Jun 3 2019, 5:59 AM
gerritbot added a comment.Jun 3 2019, 7:51 AM

Change 513936 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513936

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).Jun 3 2019, 12:00 PM
gerritbot added a comment.Jun 3 2019, 2:10 PM

Change 513940 merged by jenkins-bot:
[mediawiki/skins/Amethyst@master] Remove unused "position" field from "ResourceModules" in skin.json

https://gerrit.wikimedia.org/r/513940

gerritbot added a comment.Jun 3 2019, 2:10 PM

Change 513941 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Remove unused "position" field from "ResourceModules" in skin.json

https://gerrit.wikimedia.org/r/513941

gerritbot added a comment.Jun 5 2019, 12:22 AM

Change 513930 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513930

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.10; 2019-06-18); removed MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).Jun 5 2019, 1:00 AM
gerritbot added a comment.Jun 5 2019, 3:36 AM

Change 513933 merged by Jforrester:
[mediawiki/extensions/ImageMetrics@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513933

gerritbot added a comment.Jun 5 2019, 4:09 AM

Change 513928 merged by jenkins-bot:
[mediawiki/extensions/BreadCrumbs@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513928

gerritbot added a comment.Jun 5 2019, 4:13 AM

Change 513931 merged by jenkins-bot:
[mediawiki/extensions/ExtensionDistributor@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513931

gerritbot added a comment.Jun 5 2019, 4:13 AM

Change 513932 merged by jenkins-bot:
[mediawiki/extensions/FanBoxes@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513932

gerritbot added a comment.Jun 5 2019, 4:21 AM

Change 513937 merged by jenkins-bot:
[mediawiki/extensions/PictureGame@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513937

gerritbot added a comment.Jun 5 2019, 4:22 AM

Change 513938 merged by jenkins-bot:
[mediawiki/extensions/SectionDisqus@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513938

gerritbot added a comment.Jun 5 2019, 4:22 AM

Change 513935 merged by jenkins-bot:
[mediawiki/extensions/MultiUpload@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513935

gerritbot added a comment.Jun 5 2019, 4:35 AM

Change 513939 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513939

gerritbot added a comment.Jun 5 2019, 5:36 PM

Change 513934 merged by Jforrester:
[mediawiki/extensions/MiniInvite@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513934

gerritbot added a comment.Jun 5 2019, 6:20 PM

Change 513929 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/513929

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2019, 7:10 PM
gerritbot added a comment.Jul 17 2019, 3:06 AM

Change 523842 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/FlaggedRevs@master] Remove unused "position" field from "ResourceModules" in skin.json

https://gerrit.wikimedia.org/r/523842

gerritbot added a project: Patch-For-Review.Jul 17 2019, 3:06 AM
Legoktm added a comment.Jul 17 2019, 3:08 AM

One repo left!

gerritbot added a comment.Jul 17 2019, 5:53 PM

Change 523842 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Remove unused "position" field from "ResourceModules" in extension.json

https://gerrit.wikimedia.org/r/523842

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.15; 2019-07-23); removed MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jul 17 2019, 6:01 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 17 2019, 6:10 PM
Legoktm closed this task as Resolved.Jul 17 2019, 6:28 PM
QChris mentioned this in rSCAVb5e1868bbea2: Remove unused "position" field from "ResourceModules" in skin.json.Jan 13 2022, 9:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits