Page MenuHomePhabricator

Decide whether we want to go with a separate presentation/ sub-dir in src/
Closed, ResolvedPublic

Description

In order to separate the boundaries within our code better, it might make sense to have a dedicated presentation/ directory that contains our vue components, the styles (e.g. scss variable) and other presentation code, if any. This will be easier if we do it right at the start.

acceptance criteria

  • decide if we want that directory structure – yes
  • if we want it, implement it (i.e. rebase and possibly fix the patch below)

Patch for review: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/518022

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 518022 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: move vue code to presentation dir for clearer separation of concerns

https://gerrit.wikimedia.org/r/518022

Change 519210 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Delete hello world assets

https://gerrit.wikimedia.org/r/519210

Change 518022 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: move vue code to presentation dir for clearer separation of concerns

https://gerrit.wikimedia.org/r/518022

Change 519210 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Delete hello world assets

https://gerrit.wikimedia.org/r/519210