Page MenuHomePhabricator

Recent changes page with RC filters misses margin after heading
Closed, ResolvedPublic

Description

Special:RecentChanges shouldn’t look like this with edit filters enabled:

image.png (122×684 px, 6 KB)

Link to reproduce:
https://ru.wikipedia.org/wiki/Служебная:Свежие_правки

English Wikipedia seems to fix this with this code, which is why you probably didn’t notice the bug:

/* Adds padding above Watchlist announcements where new recentchanges/watchlist filters are enabled */
.mw-rcfilters-enabled .mw-specialpage-summary {
	margin-top: 1em;
}

This code somewhere in new filters code seems to have caused it:

.client-js #contentSub, .client-js form#mw-watchlist-resetbutton { display: none; }

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh subscribed.

Let's look at this in Q1.

This doesn't seem to affect Vector any more due to some CSS changes there, but it still reproducible e.g. with MonoBook.

Change 821313 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] rcfilters: Don't remove #contentSub on Special:Watchlist

https://gerrit.wikimedia.org/r/821313

Change 821313 merged by jenkins-bot:

[mediawiki/core@master] rcfilters: Don't remove #contentSub on Special:Watchlist

https://gerrit.wikimedia.org/r/821313

matmarex claimed this task.