Page MenuHomePhabricator
Create Task
Maniphest T227390

File on source wiki isn't deleted when the name is edited during import
Closed, ResolvedPublicBUG REPORT
Actions

Description

Tested with File:MO-WMF.jpg as the source.

  1. Imported as File:MO-WMF-20190706.jpg successfully, but the source file was not deleted.
  2. Deleted File:MO-WMF-20190706.jpg to be able to import again.
  3. Imported as File:MO-WMF.jpg successfully and the source file was deleted.

MW 1.34.0-alpha (d71db83)
FileImporter 1.0.0 (4511cfa)
FileExporter 1.0.0 (41d894d)

Details

SubjectRepoBranchLines +/-
Fix bug involving file renaming and centralauth cleanup/deletemediawiki/extensions/FileImporterwmf/1.34.0-wmf.13+43 -7
Fix bug involving file renaming and centralauth cleanup/deletemediawiki/extensions/FileImportermaster+43 -7
Customize query in gerrit

Related Objects

Event Timeline

JJMC89 created this task.Jul 6 2019, 9:43 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJul 6 2019, 9:43 PM
JJMC89 changed the subtype of this task from "Task" to "Bug Report".Jul 6 2019, 9:44 PM
JJMC89 added a subscriber: Andrew-WMDE.Jul 11 2019, 6:21 PM

It looks like @Andrew-WMDE's patch should fix this.

gerritbot added a comment.Jul 12 2019, 7:29 AM

Change 522052 had a related patch set uploaded (by WMDE-Fisch; owner: Andrew-WMDE):
[mediawiki/extensions/FileImporter@master] Fix bug involving file renaming and centralauth cleanup/delete

https://gerrit.wikimedia.org/r/522052

gerritbot added a project: Patch-For-Review.Jul 12 2019, 7:29 AM
WMDE-Fisch added a project: WMDE-QWERTY-Spike-2019-07-09.Jul 12 2019, 7:29 AM
gerritbot added a comment.Jul 12 2019, 8:07 AM

Change 522052 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Fix bug involving file renaming and centralauth cleanup/delete

https://gerrit.wikimedia.org/r/522052

WMDE-Fisch mentioned this in rEFLI05bd86e1f140: Fix bug involving file renaming and centralauth cleanup/delete.Jul 12 2019, 8:07 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 12 2019, 8:10 AM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 12 2019, 9:00 AM
WMDE-Fisch moved this task from Sprint Backlog to Demo on the WMDE-QWERTY-Spike-2019-07-09 board.Jul 12 2019, 9:24 AM
gerritbot added a comment.Jul 16 2019, 7:58 AM

Change 523618 had a related patch set uploaded (by Awight; owner: Andrew-WMDE):
[mediawiki/extensions/FileImporter@wmf/1.34.0-wmf.13] Fix bug involving file renaming and centralauth cleanup/delete

https://gerrit.wikimedia.org/r/523618

gerritbot added a project: Patch-For-Review.Jul 16 2019, 7:58 AM
gerritbot added a comment.Jul 16 2019, 8:41 AM

Change 523618 abandoned by Awight:
Fix bug involving file renaming and centralauth cleanup/delete

https://gerrit.wikimedia.org/r/523618

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2019, 9:10 AM
awight subscribed.Jul 18 2019, 10:28 AM

Quick update: This bugfix is due to go out with wmf.14 on commonswiki, which probably won't happen for group 1 wikis until next week.

• Lea_WMDE closed this task as Resolved.Jul 23 2019, 10:52 AM
• Lea_WMDE claimed this task.
• Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Spike-2019-07-09 board.
JJMC89 reassigned this task from • Lea_WMDE to Andrew-WMDE.Jul 23 2019, 2:40 PM
JJMC89 added a subscriber: • Lea_WMDE.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits