Page MenuHomePhabricator
Create Task
Maniphest T228080

Adding a second gloss results in an error
Closed, ResolvedPublic8 Estimated Story PointsBUG REPORT
Actions

Description

Steps to Reproduce:

  • Add first gloss in one language
  • Press publish
  • Add second gloss in one language
  • Press publish

Actual Results:

Danish error message:

Der opstod en fejl under forsøget på at gemme og derfor kan ændringerne ikke gennemføres.

Field "senseId" contains an ID of a Sense "L55506-S1" that could not be found.

Expected Results:

The sense should be saved.

Details

SubjectRepoBranchLines +/-
Avoid self-conflict in wbleditsenseelements API modulemediawiki/extensions/WikibaseLexememaster+89 -5
Customize query in gerrit

Related Objects

Event Timeline

Fnielsen created this task.Jul 15 2019, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2019, 5:20 PM
Fnielsen added a comment.Jul 15 2019, 5:21 PM

If the page is reloaded by the browser then it is possible to enter the second gloss.

Fnielsen added a comment.Jul 15 2019, 9:07 PM

The error also appears when the first gloss is reedited

matej_suchanek added a project: Wikidata Lexicographical data.Jul 16 2019, 7:05 AM
Lydia_Pintscher added a project: Wikidata-Campsite.Jul 16 2019, 9:24 AM
Lydia_Pintscher subscribed.

Can confirm when adding a second Gloss to a newly created Sense (no page-reload in between).

Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Jul 16 2019, 9:24 AM
Ladsgroup subscribed.Jul 16 2019, 10:59 AM

It's the same issue as T225070#5334629 We probably fix both in one go.

• alaa_wmde subscribed.Jul 16 2019, 12:13 PM

We should add a regression test for this case here

• alaa_wmde triaged this task as High priority.Jul 16 2019, 12:29 PM
• alaa_wmde set the point value for this task to 8.
• alaa_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
gerritbot added a comment.Jul 16 2019, 5:38 PM

Change 523785 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Avoid self-conflict in wbleditsenseelements API module

https://gerrit.wikimedia.org/r/523785

gerritbot added a project: Patch-For-Review.Jul 16 2019, 5:38 PM
Ladsgroup claimed this task.Jul 16 2019, 5:38 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 16 2019, 5:38 PM
gerritbot added a comment.Jul 18 2019, 12:29 PM

Change 523785 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Avoid self-conflict in wbleditsenseelements API module

https://gerrit.wikimedia.org/r/523785

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 18 2019, 1:00 PM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 18 2019, 1:04 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2019, 1:10 PM
Lydia_Pintscher closed this task as Resolved.Jul 19 2019, 10:26 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

\o/
Verified on https://wikidata.beta.wmflabs.org/wiki/Lexeme:L12

Fnielsen added a comment.Aug 1 2019, 9:03 AM

Yes, I experience no error on the main sight now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL