Page MenuHomePhabricator
Create Task
Maniphest T228269

'oathauth-module-invalid' lacks i18n en/qqq.json keys
Closed, ResolvedPublic
Actions

Description

ea984e5c2b2e added some more code and i18n keys but oathauth-module-invalid was missing. Spotted today when 2FA for translatewiki.net broke (cfr. T228268) making the error MWException message not helpful.

Details

SubjectRepoBranchLines +/-
Add missing oathauth-module-invalid messagemediawiki/extensions/OATHAuthREL1_34+4 -1
Add missing oathauth-module-invalid messagemediawiki/extensions/OATHAuthmaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

MarcoAurelio created this task.Jul 17 2019, 11:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2019, 11:31 AM
Reedy added a subscriber: ItSpiderman.Jul 17 2019, 4:25 PM
MarcoAurelio added a comment.Sep 28 2019, 12:10 PM

Hi @ItSpiderman - Which wording shall we use for this new key? Thanks.

MarcoAurelio mentioned this in T237114: oathauth-module-invalid on Mediawiki 1.34.Nov 1 2019, 5:02 PM
Kizule claimed this task.Nov 1 2019, 5:47 PM
Kizule subscribed.

OATHAuth module is invalid?

Restricted Application added a project: User-Kizule. · View Herald TranscriptNov 1 2019, 5:47 PM
ItSpiderman added a comment.Nov 4 2019, 7:29 AM

This error occurs when module that user has registered cannot be instantiated, like if WebAuthn module has been enabled, and user enabled it, but then WebAuthn was disabled.

So i would suggest: "OATHAuth module user has registered is invalid" or something to that effect.

Thank you

MarcoAurelio added a comment.Nov 4 2019, 2:04 PM

The OATHAuth module that the user has registered is invalid. for en.json then.

gerritbot added a comment.Nov 4 2019, 8:55 PM

Change 548503 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/OATHAuth@master] Add missing oathauth-module-invalid message

https://gerrit.wikimedia.org/r/548503

gerritbot added a project: Patch-For-Review.Nov 4 2019, 8:56 PM
Reedy closed this task as Resolved.Nov 9 2019, 8:14 PM
gerritbot added a comment.Nov 9 2019, 8:16 PM

Change 548503 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@master] Add missing oathauth-module-invalid message

https://gerrit.wikimedia.org/r/548503

gerritbot added a comment.Nov 9 2019, 8:26 PM

Change 549984 had a related patch set uploaded (by Reedy; owner: Zoranzoki21):
[mediawiki/extensions/OATHAuth@REL1_34] Add missing oathauth-module-invalid message

https://gerrit.wikimedia.org/r/549984

gerritbot added a comment.Nov 9 2019, 8:30 PM

Change 549984 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@REL1_34] Add missing oathauth-module-invalid message

https://gerrit.wikimedia.org/r/549984

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 9 2019, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 9 2019, 9:10 PM
gerritbot added a comment.Dec 18 2019, 11:53 AM

Change 559028 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@REL1_34] RELEASE-NOTES-1.34: Add notes for T212067 and T228269 backports

https://gerrit.wikimedia.org/r/559028

gerritbot added a project: Patch-For-Review.Dec 18 2019, 11:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL