Page MenuHomePhabricator
Create Task
Maniphest T228408

Create and inject configuration for Special:EntityData endpoint
Closed, ResolvedPublic
Actions

Description

We need to inject the API/SpecialPage endpoint(s) that our repositories are supposed to use for reading and writing into our app.

For now, it should be enough to only create and inject configuration for the Special:EntityData reading endpoint.

Optionally: Think about whether we really want to use Special:EntityData or if we do not need to use wbgetentities any, because we also need language fallback for labels?

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
bridge: pass Special:EntityData URL to app, initialize servicesmediawiki/extensions/Wikibasemaster+2 K -23
bridge: add WbRepo interface for wbRepo config valuemediawiki/extensions/Wikibasemaster+70 -50
bridge: add interface for configuration objectmediawiki/extensions/Wikibasemaster+18 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Jul 18 2019, 11:47 AM
Lucas_Werkmeister_WMDE subscribed.EditedJul 18 2019, 1:38 PM

I don’t think we need separate configuration for this – the client already knows the general article path of the repo:

mw.loader.using( 'mw.config.values.wbRepo', () => {
    const repoConfig = mw.config.get( 'wbRepo' );
    console.log( repoConfig.url + repoConfig.articlePath.replace( '$1', 'Special:EntityData' ) );
} );

And just for future reference, because I happened to see it at the same time, there’s also a wikibase.client.getMwApiForRepo module that we should be able to use for wbgetentities.

Michael added a comment.Jul 18 2019, 1:53 PM

Oh, sounds good! Let's use that!

Lucas_Werkmeister_WMDE claimed this task.Jul 19 2019, 11:59 AM
Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-2 board.

I’ll try to do the “inject” part of this now.

gerritbot added a comment.Jul 19 2019, 1:31 PM

Change 524512 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add interface for configuration object

https://gerrit.wikimedia.org/r/524512

gerritbot added a project: Patch-For-Review.Jul 19 2019, 1:31 PM

Change 524513 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add WbRepo interface for wbRepo config value

https://gerrit.wikimedia.org/r/524513

gerritbot added a comment.Jul 19 2019, 1:31 PM

Change 524514 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: pass and initialize ServiceRepositories in ApplicationConfig

https://gerrit.wikimedia.org/r/524514

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-2 board.Jul 19 2019, 1:33 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Michael moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-2 board.Jul 22 2019, 10:12 AM
Michael moved this task from Done to Peer Review on the Wikidata-Bridge-Sprint-2 board.
gerritbot added a comment.Jul 23 2019, 11:40 AM

Change 524512 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add interface for configuration object

https://gerrit.wikimedia.org/r/524512

gerritbot added a comment.Jul 23 2019, 11:40 AM

Change 524513 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add WbRepo interface for wbRepo config value

https://gerrit.wikimedia.org/r/524513

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 23 2019, 12:00 PM
gerritbot added a comment.Jul 23 2019, 12:37 PM

Change 524514 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: pass Special:EntityData URL to app, initialize services

https://gerrit.wikimedia.org/r/524514

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2019, 1:10 PM
Michael removed Lucas_Werkmeister_WMDE as the assignee of this task.Jul 23 2019, 1:12 PM
Michael moved this task from Peer Review to To do on the Wikidata-Bridge-Sprint-2 board.

This still requires some cleanup regarding eslint warnings.

Michael updated the task description. (Show Details)Jul 23 2019, 1:12 PM
• Matthias_Geisler_WMDE closed this task as Resolved.Jul 25 2019, 12:26 PM
• Matthias_Geisler_WMDE moved this task from To do to Done on the Wikidata-Bridge-Sprint-2 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL