Page MenuHomePhabricator

Rollback links in wmf.15 now have two square brackets around them, not one
Closed, ResolvedPublic0 Story Points

Description

I assume this is caused by styling-related changes for mobile, like the last time.

(I don't think this is a train blocker, so not tagging as such.)

Event Timeline

Jdforrester-WMF triaged this task as High priority.Tue, Jul 23, 3:03 PM
Jdforrester-WMF created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Jul 23, 3:03 PM

Which page are you seeing this @Jdforrester-WMF ? Recent changes? I can get a patch up today - can you review if I do?

Jdforrester-WMF added a comment.EditedTue, Jul 23, 6:03 PM

Which page are you seeing this @Jdforrester-WMF ? Recent changes?

Sorry, on desktop diff pages, e.g. https://www.mediawiki.org/w/index.php?diff=3318463&oldid=3310361&title=Wikimedia_Product (you need to be +sysop to see it).

I can get a patch up today - can you review if I do?

Yes, happy to help.

Change 525141 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Don't double wrap rollback links

https://gerrit.wikimedia.org/r/525141

Change 525141 merged by jenkins-bot:
[mediawiki/core@master] Don't double wrap rollback links

https://gerrit.wikimedia.org/r/525141

Change 525172 had a related patch set uploaded (by Jforrester; owner: Jdlrobson):
[mediawiki/core@wmf/1.34.0-wmf.15] Don't double wrap rollback links

https://gerrit.wikimedia.org/r/525172

Change 525172 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.15] Don't double wrap rollback links

https://gerrit.wikimedia.org/r/525172

Mentioned in SAL (#wikimedia-operations) [2019-07-23T23:42:23Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.15/includes/diff/DifferenceEngine.php: T228766 Don't double wrap rollback links (duration: 00m 56s)

Thanks for taking care of that James!