Page MenuHomePhabricator
Create Task
Maniphest T228766

Rollback links in wmf.15 now have two square brackets around them, not one
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

I assume this is caused by styling-related changes for mobile, like the last time.

(I don't think this is a train blocker, so not tagging as such.)

Details

SubjectRepoBranchLines +/-
Don't double wrap rollback linksmediawiki/corewmf/1.34.0-wmf.15+2 -1
Don't double wrap rollback linksmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF triaged this task as High priority.Jul 23 2019, 3:03 PM
Jdforrester-WMF created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2019, 3:03 PM
Jdforrester-WMF added a project: Regression.Jul 23 2019, 3:04 PM
Jdforrester-WMF added subscribers: Jdlrobson, kostajh.

Probably caused by aaea6a0fc072408ac00fef912b685eedf9a6d2d4; tagging in T219948.

Jdlrobson added a comment.Jul 23 2019, 3:50 PM

Which page are you seeing this @Jdforrester-WMF ? Recent changes? I can get a patch up today - can you review if I do?

Jdforrester-WMF added a comment.EditedJul 23 2019, 6:03 PM
In T228766#5357650, @Jdlrobson wrote:

Which page are you seeing this @Jdforrester-WMF ? Recent changes?

Sorry, on desktop diff pages, e.g. https://www.mediawiki.org/w/index.php?diff=3318463&oldid=3310361&title=Wikimedia_Product (you need to be +sysop to see it).

I can get a patch up today - can you review if I do?

Yes, happy to help.

gerritbot added a comment.Jul 23 2019, 7:08 PM

Change 525141 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Don't double wrap rollback links

https://gerrit.wikimedia.org/r/525141

gerritbot added a project: Patch-For-Review.Jul 23 2019, 7:08 PM
gerritbot added a comment.Jul 23 2019, 9:13 PM

Change 525141 merged by jenkins-bot:
[mediawiki/core@master] Don't double wrap rollback links

https://gerrit.wikimedia.org/r/525141

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 23 2019, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 23 2019, 10:10 PM
gerritbot added a comment.Jul 23 2019, 11:27 PM

Change 525172 had a related patch set uploaded (by Jforrester; owner: Jdlrobson):
[mediawiki/core@wmf/1.34.0-wmf.15] Don't double wrap rollback links

https://gerrit.wikimedia.org/r/525172

gerritbot added a project: Patch-For-Review.Jul 23 2019, 11:27 PM
Jdforrester-WMF assigned this task to Jdlrobson.Jul 23 2019, 11:31 PM
gerritbot added a comment.Jul 23 2019, 11:39 PM

Change 525172 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.15] Don't double wrap rollback links

https://gerrit.wikimedia.org/r/525172

Stashbot added a comment.Jul 23 2019, 11:42 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-23T23:42:23Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.15/includes/diff/DifferenceEngine.php: T228766 Don't double wrap rollback links (duration: 00m 56s)

Jdforrester-WMF closed this task as Resolved.Jul 23 2019, 11:43 PM
Jdforrester-WMF edited projects, added MW-1.34-notes (1.34.0-wmf.15; 2019-07-23); removed Patch-For-Review, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).

Hot-deployed. Thank you!

Jdlrobson added a comment.Jul 24 2019, 6:20 PM

Thanks for taking care of that James!

Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits