Page MenuHomePhabricator

Handle language fallback chain consistently in Statement UI
Closed, ResolvedPublic

Description

If a qualifier label is not available in a user's language (as defined by their language fallback chain), we are displaying the wb-language-fallback-indicator markup that is returned from Wikibase. This is a superscript element which displays the language that the label being shown is written in.

This behavior should also be applied to the following UI elements:

  • Top-level property for a given StatementsPanel
  • Entity label for a given statement within this panel (the ItemWidget element)

Event Timeline

egardner created this task.Aug 1 2019, 5:58 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptAug 1 2019, 5:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ramsey-WMF triaged this task as Low priority.Aug 1 2019, 6:04 PM
Ramsey-WMF moved this task from Untriaged to Triaged on the Multimedia board.

@Ramsey-WMF and @PDrouin-WMF, I've language-indicatored all the things – let me know if this looks right to you:

Change 528902 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/WikibaseMediaInfo@master] Handle language fallback chain consistently in Statement UI

https://gerrit.wikimedia.org/r/528902

Looks good enough for me, thanks @egardner!

ship it! 😄

Change 528902 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Handle language fallback chain consistently in Statement UI

https://gerrit.wikimedia.org/r/528902

Tested on Beta, seems to work well.

Ramsey-WMF closed this task as Resolved.Sep 10 2019, 1:27 AM

Tested on production (on mobile too!). Works.