Talk page replies lost when clicking on links
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 2 2019, 9:04 PM

Description

Edits can be lost by accidentally clicking links in a talk topic. (original report: https://phabricator.wikimedia.org/T228278#5387895)

Replication steps:

View any talk comment with a link (e.g. username signature)

Example URL: https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain#/talk/1

Enter some content into the textarea (start writing a reply)
Click "Jdlrobson" or other link.

Expected: I am prompted to whether I want to leave
Actual: I am navigated to the link

Details

	Subject	Repo	Branch	Lines +/-
	Clicking links triggers onBeforeExit	mediawiki/extensions/MobileFrontend	master	+22 -4

Customize query in gerrit

Related Objects

Mentioned In: T228278: Edits lost when writing replies on talk page before leaving the page
Mentioned Here: T228278: Edits lost when writing replies on talk page before leaving the page

Event Timeline

Jdlrobson created this task.Aug 2 2019, 9:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2019, 9:04 PM

Jdlrobson triaged this task as High priority.Aug 2 2019, 9:04 PM

Jdlrobson mentioned this in T228278: Edits lost when writing replies on talk page before leaving the page.

Jdlrobson updated the task description. (Show Details)

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.Aug 2 2019, 9:06 PM

Jdlrobson moved this task from Needs Analysis to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Urbanecm added a subscriber: Patriccck.Aug 2 2019, 9:07 PM

Change 527645 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Clicking links triggers onBeforeExit

https://gerrit.wikimedia.org/r/527645

gerritbot added a project: Patch-For-Review.Aug 2 2019, 9:07 PM

Jdlrobson renamed this task from Edits lost when clicking on links to Talk page replies lost when clicking on links.Aug 2 2019, 9:34 PM

Change 527645 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Clicking links triggers onBeforeExit

https://gerrit.wikimedia.org/r/527645

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2019, 3:10 AM

Jdlrobson assigned this task to Edtadros.Aug 5 2019, 2:37 PM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

• alexhollender_WMF reassigned this task from Edtadros to ovasileva.Aug 6 2019, 3:21 PM

• alexhollender_WMF added a subscriber: Edtadros.

@Jdlrobson - not a blocker, but still not fixed:
Replications steps:

go to https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain#/talk/1
click on Jdlrobson
page navigates to link, no confirmation is shown

@ovasileva works for me. Remember you need to put something in the textarea to trigger the confirmation. If the user hasn't inputted anything, we let them navigate away.

Updated description since it was lacking that step :)

MBinder_WMF reassigned this task from Edtadros to ovasileva.Aug 7 2019, 5:20 PM

QA:

View any talk comment with a link (e.g. username signature)