Page MenuHomePhabricator

[AMC] Update icon for "Page information" menu item
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

Switch the icon to use infoFilled (note Page information appears in the more menu for article pages and user pages).

currentupdated

Developer notes

This is currently using the "info" icon in wikimedia.ui. Change it to use "infoFilled" and check with Alex that the icon used matches the attachment. If it's not we'll need to update the icon in OOUI (out of scope for this task).
DO NOT put a new SVG icon into the Minerva repo.

QA instructions

QA Results

ACStatusDetails
1T230693#5461508

Event Timeline

alexhollender renamed this task from Update icon for "Page information" menu item to [AMC] Update icon for "Page information" menu item.Aug 18 2019, 3:26 PM
ovasileva triaged this task as Medium priority.Aug 20 2019, 6:58 PM
ovasileva moved this task from Needs Prioritization to Upcoming on the Readers-Web-Backlog board.
Jdlrobson updated the task description. (Show Details)
ovasileva removed the point value for this task.
ovasileva set the point value for this task to 2.
ovasileva added a subscriber: ovasileva.

Change 533237 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] [icon] [toolbar] update page info icon

https://gerrit.wikimedia.org/r/533237

This is currently using the "info" icon in wikimedia.ui. Change it to use "infoFilled" and check with Alex that the icon used matches the attachment. If it's not we'll need to update the icon in OOUI (out of scope for this task).
DO NOT put a new SVG icon into the Minerva repo.

This is the icon generated on my machine via http://localhost:8181/w/load.php?modules=wikimedia.ui&image=infoFilled&format=original&lang=en&skin=minerva:

Here's what it looks like in context:

When I run them both through:

~/dev/wmf/boxwiki/core/extensions/MobileFrontend/node_modules/svgo/bin/svgo --config=/home/stephen/dev/wmf/boxwiki/core/extensions/MobileFrontend/.svgo.yml infoFilled.svg

The diff shows a wrapping <g fill="#54595d"> on the last path.

The visual diff compare infoFilled.svg ~/desk/infoFilled.svg png:- | montage -mode concatenate infoFilled.svg png:- ~/desk/infoFilled.svg png:- > diff.png:

As you can see, the opacity is lighter than the one in the task but it fits in with the other icons so I think it's ok. @alexhollender, is it ok?

@Niedzielski yes that looks correct. General FYI: I always provide black SVGs, as my understanding is that the shift to #54595d happens on the frontend. Can you update the QA instructions regarding where this can be tested?

@alexhollender, sounds good. Updated QA (note: patch not yet merged).

Change 533237 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] [icon] [toolbar] update page info icon

https://gerrit.wikimedia.org/r/533237

Edtadros added a subscriber: Edtadros.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Instructions

visit an article page on the mobile site with the MinervaNeue skin and AMC enabled (e.g., https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog)
open the overflow menu
✅ AC1: verify that the icon for Page information matches the mockup above