Page MenuHomePhabricator
Create Task
Maniphest T230693

[AMC] Update icon for "Page information" menu item
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
• alexhollender_WMF
Aug 18 2019, 2:55 PM
Tags
Referenced Files
F30210212: T230693.png
Sep 3 2019, 2:42 PM
F30154643: localhost_8181_wiki_Foo.png
Aug 29 2019, 3:08 PM
F30154659: diff.png
Aug 29 2019, 3:08 PM
F30154644: infoFilled.svg
Aug 29 2019, 3:08 PM
F30046438: infoFilled.svg
Aug 18 2019, 2:55 PM
F30046436: image.png
Aug 18 2019, 2:55 PM
F30046437: image.png
Aug 18 2019, 2:55 PM
Subscribers
Aklapper
• alexhollender_WMF
Edtadros
Masumrezarock100
• Niedzielski
ovasileva

Description

Description

Switch the icon to use infoFilled (note Page information appears in the more menu for article pages and user pages).

currentupdated
image.png (1×750 px, 208 KB)
image.png (1×750 px, 208 KB)

infoFilled.svg263 BDownload

Developer notes

This is currently using the "info" icon in wikimedia.ui. Change it to use "infoFilled" and check with Alex that the icon used matches the attachment. If it's not we'll need to update the icon in OOUI (out of scope for this task).
DO NOT put a new SVG icon into the Minerva repo.

QA instructions

QA Results

ACStatusDetails
1✅T230693#5461508

Details

SubjectRepoBranchLines +/-
[icon] [toolbar] update page info iconmediawiki/skins/MinervaNeuemaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

• alexhollender_WMF created this task.Aug 18 2019, 2:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2019, 2:55 PM
• alexhollender_WMF updated the task description. (Show Details)Aug 18 2019, 2:56 PM
• alexhollender_WMF renamed this task from Update icon for "Page information" menu item to [AMC] Update icon for "Page information" menu item.Aug 18 2019, 3:26 PM
Jdlrobson assigned this task to ovasileva.Aug 19 2019, 3:10 PM
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
ovasileva triaged this task as Medium priority.Aug 20 2019, 6:58 PM
ovasileva moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog board.
ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.Aug 27 2019, 4:46 PM
Jdlrobson updated the task description. (Show Details)Aug 27 2019, 4:49 PM
Jdlrobson updated the task description. (Show Details)
ovasileva set the point value for this task to 2.Aug 27 2019, 4:49 PM
ovasileva moved this task from Needs Analysis to Ready for Development on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
ovasileva removed ovasileva as the assignee of this task.Aug 27 2019, 4:56 PM
ovasileva removed the point value for this task.
ovasileva set the point value for this task to 2.
ovasileva subscribed.
gerritbot added a comment.Aug 29 2019, 2:55 PM

Change 533237 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] [icon] [toolbar] update page info icon

https://gerrit.wikimedia.org/r/533237

gerritbot added a project: Patch-For-Review.Aug 29 2019, 2:55 PM
• Niedzielski subscribed.Aug 29 2019, 3:08 PM

This is currently using the "info" icon in wikimedia.ui. Change it to use "infoFilled" and check with Alex that the icon used matches the attachment. If it's not we'll need to update the icon in OOUI (out of scope for this task).
DO NOT put a new SVG icon into the Minerva repo.

This is the icon generated on my machine via http://localhost:8181/w/load.php?modules=wikimedia.ui&image=infoFilled&format=original&lang=en&skin=minerva:

infoFilled.svg275 BDownload

Here's what it looks like in context:

localhost_8181_wiki_Foo.png (1×1 px, 178 KB)

When I run them both through:

~/dev/wmf/boxwiki/core/extensions/MobileFrontend/node_modules/svgo/bin/svgo --config=/home/stephen/dev/wmf/boxwiki/core/extensions/MobileFrontend/.svgo.yml infoFilled.svg

The diff shows a wrapping <g fill="#54595d"> on the last path.

The visual diff compare infoFilled.svg ~/desk/infoFilled.svg png:- | montage -mode concatenate infoFilled.svg png:- ~/desk/infoFilled.svg png:- > diff.png:

diff.png (19×57 px, 806 B)

As you can see, the opacity is lighter than the one in the task but it fits in with the other icons so I think it's ok. @alexhollender, is it ok?

• Niedzielski assigned this task to • alexhollender_WMF.Aug 29 2019, 3:08 PM
• Niedzielski moved this task from Ready for Development to Needs Design Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
• alexhollender_WMF removed • alexhollender_WMF as the assignee of this task.Aug 29 2019, 3:22 PM
• alexhollender_WMF moved this task from Needs Design Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

@Niedzielski yes that looks correct. General FYI: I always provide black SVGs, as my understanding is that the shift to #54595d happens on the frontend. Can you update the QA instructions regarding where this can be tested?

• alexhollender_WMF updated the task description. (Show Details)Aug 29 2019, 3:23 PM
• Niedzielski updated the task description. (Show Details)Aug 29 2019, 3:25 PM

@alexhollender, sounds good. Updated QA (note: patch not yet merged).

• Niedzielski moved this task from Needs QA to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Aug 29 2019, 3:26 PM
Jdlrobson assigned this task to Edtadros.Aug 29 2019, 8:30 PM
Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
gerritbot added a comment.Aug 29 2019, 10:17 PM

Change 533237 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] [icon] [toolbar] update page info icon

https://gerrit.wikimedia.org/r/533237

Restricted Repository Identity mentioned this in rSKIN1467391d477b: Update git submodules.Aug 29 2019, 10:18 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 29 2019, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 29 2019, 11:10 PM
Edtadros reassigned this task from Edtadros to ovasileva.Sep 3 2019, 2:42 PM
Edtadros moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Edtadros subscribed.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Instructions

visit an article page on the mobile site with the MinervaNeue skin and AMC enabled (e.g., https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog)
open the overflow menu
✅ AC1: verify that the icon for Page information matches the mockup above

T230693.png (2×1 px, 392 KB)

Edtadros added a project: Product-QA (RW-Test-Cases).Sep 3 2019, 2:43 PM
Edtadros updated the task description. (Show Details)
ovasileva closed this task as Resolved.Sep 4 2019, 11:53 AM

Looks good!

ovasileva moved this task from Backlog to Advanced Mobile Contributions on the Product-QA (RW-Test-Cases) board.Mar 2 2020, 6:39 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMar 2 2020, 6:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL