Page MenuHomePhabricator
Create Task
Maniphest T231050

Issue with filter menu width on mobile (OOUI menuSelectWidget)
Open, LowPublicBUG REPORT
Actions

Description

Highlighting can be enabled if following a URL e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&limit=50&days=7&enhanced=1&damaging__likelygood_color=c2&urlversion=2

Visit this page in a mobile resolution (320x568).

expected: The menu width should match the width of the Filter button
actual:

image.png (1×802 px, 171 KB)

Developer notes

The element with the problem has the classes: oo-ui-widget oo-ui-widget-enabled oo-ui-selectWidget oo-ui-selectWidget-unpressed oo-ui-clippableElement-clippable oo-ui-floatableElement-floatable oo-ui-menuSelectWidget mw-rcfilters-ui-menuSelectWidget mw-rcfilters-ui-menuSelectWidget-view-namespaces

It has an inline style set including a width. The calculated width appears to be 10px too big.

Likely an issue with OOUI - "mw-rcfilters-ui-menuSelectWidget-view-namespaces" - the OOUI library sets the width and it's setting it larger than it should be. Looks like it's border box related and will likely need help from @Volker_E to fix this one.

Actual Results:

Expected Results:

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Aug 22 2019, 10:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2019, 10:50 PM
Jdlrobson added a parent task: T229360: [Tracking/Epic] Problems with RecentChanges and Watchlist advanced mobile contribution experience.Aug 22 2019, 10:52 PM
Jdlrobson added a project: Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1).Aug 22 2019, 11:02 PM
Jdlrobson added a subscriber: ovasileva.

Ready for discussion @ovasileva but I think this might be a tricky one and might not be worth the effort right now.

Jdlrobson assigned this task to ovasileva.Aug 22 2019, 11:03 PM
ovasileva triaged this task as Low priority.Aug 23 2019, 3:54 PM
ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1).
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.Aug 23 2019, 4:08 PM
Jdlrobson added a project: MediaWiki-Recent-changes.Oct 15 2019, 4:23 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 15 2019, 4:23 PM
ovasileva edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.Oct 15 2019, 4:24 PM
Jdlrobson moved this task from Backlog to Triaged on the Advanced Mobile Contributions board.Dec 10 2020, 11:09 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Sep 15 2021, 5:12 PM
Jdlrobson removed a project: Web-Team-Backlog (Tracking).Oct 20 2021, 3:28 PM
Aklapper removed ovasileva as the assignee of this task.Mar 13 2022, 7:53 PM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits