Page MenuHomePhabricator

Design: Determine Loading View for Revision Details Pop-up in WWT
Closed, ResolvedPublic

Description

As an engineer, I want to know the visual requirements for the revision details pop-up when the data is loading, so that I can implement a user-friendly pop-up.

Acceptance Criteria:
• Provide a mockup/visual example of the revision details when some of the data (i.e. edit summary) is still loading
• Provide a visual indicator of the loading state within the pop-up

Event Timeline

ifried renamed this task from Determine Loading View for Revision Details Pop-up in WWT to Design: Determine Loading View for Revision Details Pop-up in WWT.Aug 23 2019, 7:44 PM

So, will we need both partial and full loading states? What all would have already loaded in the partial state?

Before being opened, the pop-up will already have access to: username, userId, revisionId, revisionTime, and score (authorship percentage of the page).

I've updated the ticket. In short, there may be times when the data Sam listed ( username, userId, revisionId, revisionTime, and score) will be presented, but the edit summary may not immediately load. We'll want to give some visual indicator to the user, so they understand that more data will be generated soon.

If the edit summary is the only thing that we'll be waiting to load we could use a content placeholder with an animation, and then switch it out with the summary once we have it - https://codepen.io/prtksxna/pen/OJLmVXZ (data will load after 3 seconds)

Screenshot 2019-08-27 at 11.11.31 AM.png (468×756 px, 36 KB)

@Prtksxna Thank you! I have updated the associated ticket: T231115. Let me know if it looks good to you or if you have any concerns.

We are now implementing the "quick" version of the proposal in T231115 -- and, after implementation and testing, we can see if want to proceed with the full version or leave as is. For this reason, I'm marking the design portion of this work as Resolved.