API action=edit with errorformat=html returns a redundant 'hookaborted' error even when an error message is set
Closed, ResolvedPublic
Actions

Description

For some edits, API action=edit with errorformat=html returns a redundant 'hookaborted' error even when an error message is set.

For example, trying to edit an UploadWizard 'Campaign' page with invalid JSON:

https://commons.wikimedia.beta.wmflabs.org/wiki/Special:ApiSandbox#action=edit&format=json&errorformat=html&title=Campaign%3Atest&text=%7B

{
    "errors": [
        {
            "code": "eventlogging-invalid-json",
            "module": "edit",
            "*": "Invalid JSON"
        },
        {
            "code": "hookaborted",
            "module": "edit",
            "*": "The modification you tried to make was aborted by an extension."
        }
    ],
    "servedby": "deployment-mediawiki-09",
    "*": "See https://commons.wikimedia.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce&gt; for notice of API deprecations and breaking changes."
}

I also noticed this in my work on AbuseFilter and SpamBlacklist in T229539.

Details

	Subject	Repo	Branch	Lines +/-
	EditPage: Don't set 'hookaborted' error if the hook set a better error	mediawiki/core	master	+4 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	matmarex	T211443 Remove SpamBlacklist error handling from ApiVisualEditorEdit.php
Resolved	matmarex	T229539 AbuseFilter and SpamBlacklist return a "successful" action=edit API response when they prevent edits
Resolved	matmarex	T229532 VisualEditor should use errorformat=html and maybe drop some of our custom error messages in favor of default ones
Resolved	matmarex	T231253 API action=edit with errorformat=html returns a redundant 'hookaborted' error even when an error message is set

Event Timeline

matmarex created this task.Aug 26 2019, 9:24 PM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptAug 26 2019, 9:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

matmarex claimed this task.Aug 26 2019, 9:24 PM

matmarex added a parent task: T229532: VisualEditor should use errorformat=html and maybe drop some of our custom error messages in favor of default ones.

Change 532465 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] EditPage: Don't set 'hookaborted' error if the hook set a better error

https://gerrit.wikimedia.org/r/532465

gerritbot added a project: Patch-For-Review.Aug 26 2019, 9:25 PM

WDoranWMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Aug 26 2019, 9:36 PM

WDoranWMF moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.

matmarex mentioned this in T229539: AbuseFilter and SpamBlacklist return a "successful" action=edit API response when they prevent edits.Aug 26 2019, 9:59 PM

matmarex added a project: VisualEditor (Current work).Aug 26 2019, 10:01 PM

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Anomie moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Aug 27 2019, 1:20 PM

matmarex updated the task description. (Show Details)Aug 27 2019, 4:15 PM

WDoranWMF triaged this task as Medium priority.Aug 28 2019, 3:08 AM

Anomie moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Sep 3 2019, 3:03 PM

Change 532465 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Don't set 'hookaborted' error if the hook set a better error