Page MenuHomePhabricator
Create Task
Maniphest T231825

Auto-save not working when editing lede section on mobile
Closed, ResolvedPublic
Actions

Description

  1. Edit a lede section in mobile VE (make sure you type a space so a history item is committed)
  2. Reload the page
  3. Observe your changes are lost

Details

SubjectRepoBranchLines +/-
Don't cast `0` to `null` when passing sectionId to VEmediawiki/extensions/MobileFrontendmaster+4 -3
Customize query in gerrit

Event Timeline

Esanders created this task.Sep 2 2019, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2019, 3:25 PM
Esanders claimed this task.Sep 2 2019, 3:30 PM
Esanders updated the task description. (Show Details)
gerritbot added a comment.Sep 2 2019, 3:32 PM

Change 533933 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Don't cast 0 to null when passing sectionId to VE

https://gerrit.wikimedia.org/r/533933

gerritbot added a project: Patch-For-Review.Sep 2 2019, 3:32 PM
Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.Sep 2 2019, 3:32 PM
Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.
ppelberg awarded a token.Sep 2 2019, 3:36 PM
gerritbot added a comment.Sep 2 2019, 5:02 PM

Change 533933 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Don't cast 0 to null when passing sectionId to VE

https://gerrit.wikimedia.org/r/533933

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2019, 5:10 PM
• matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Sep 2 2019, 5:43 PM
• matmarex added a project: Editing QA.Sep 6 2019, 1:45 PM
• matmarex moved this task from Inbox to Low Priority on the Editing QA board.Sep 9 2019, 10:57 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Sep 10 2019, 7:34 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
ppelberg closed this task as Resolved.Oct 22 2019, 12:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits