Page MenuHomePhabricator
Create Task
Maniphest T231848

If logged out, editing lede section with an infobox takes you to the infobox, not the first paragraph
Closed, ResolvedPublic
Actions

Description

T225936 makes it so that when a logged in contributor taps to "edit" an article that contains an infobox in its lede section, they are taken directly to the first paragraph of text.

As noted in T225936#5407020, the fix in T225936 only applies to logged in contributors. Read: logged out contributors are shown the infobox when tapping "edit."

This video demonstrates the issue: https://youtu.be/8pYcWMbJciU

Details

SubjectRepoBranchLines +/-
VE: Scroll past infobox after showing anon editor warningmediawiki/extensions/MobileFrontendmaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

• ppelberg created this task.Sep 3 2019, 2:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2019, 2:04 AM
• ppelberg mentioned this in T225936: Editing lede section with an infobox takes you to the infobox, not the first paragraph.Sep 3 2019, 2:05 AM
• ppelberg added subscribers: Esanders, matmarex.
In T225936#5407020, @Esanders wrote:

@matmarex I note that the scrolling doesn't work for logged out users (I assume due to the login overlay we show).

gerritbot added a comment.Sep 5 2019, 8:01 PM

Change 534675 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] VE: Scroll past infobox after showing anon editor warning

https://gerrit.wikimedia.org/r/534675

gerritbot added a project: Patch-For-Review.Sep 5 2019, 8:01 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Sep 5 2019, 8:02 PM
matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Sep 6 2019, 12:48 PM

Change 534675 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] VE: Scroll past infobox after showing anon editor warning

https://gerrit.wikimedia.org/r/534675

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 6 2019, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 6 2019, 1:10 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Sep 6 2019, 1:46 PM
matmarex added a project: Editing QA.
matmarex moved this task from Inbox to Low Priority on the Editing QA board.Sep 9 2019, 10:57 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Sep 10 2019, 7:20 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• ppelberg closed this task as Resolved.Oct 9 2019, 1:09 AM
• ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL