Page MenuHomePhabricator

Update Translate for changes in AbuseFilter and SpamBlacklist API error responses
Open, HighPublic

Description

API error responses generated by AbuseFilter and SpamBlacklist have changed, as announced here: https://lists.wikimedia.org/pipermail/mediawiki-api-announce/2019-September/000148.html (relevant task: T229539).

It appears you have special handling for the old responses. It should be updated, otherwise they will probably show a generic error message instead of a more specific one.

extensions/Translate/resources/js/ext.translate.editor.js:
  248: 				} else if ( editResp.spamblacklist ) {

Event Timeline

Change 536173 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Mark custom AbuseFilter and SpamBlacklist handling for removal

https://gerrit.wikimedia.org/r/536173

Nikerabbit added a subscriber: Nikerabbit.

No updates are necessary to handle the new format. I have marked the code for removal once backwards compatibility is no longer required.

Change 536173 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Mark custom AbuseFilter and SpamBlacklist handling for removal

https://gerrit.wikimedia.org/r/536173

Nice… This is basically the perfect case I was hoping to see when making the API changes :D