Logout button on mobile web misaligned
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Force_Radical
	Sep 15 2019, 4:26 AM

Description

The logout button isn't aligned at the center of the container. This happens on all sites when AMC is disabled.

Screenshot_20190915-095137.png (1×720 px, 62 KB)

QA Results

AC	Status	Details
1	✅	T232943#5504898

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T226562 AMC - display labels for toolbar actions on larger screens
Resolved	• alexhollender_WMF	T229440 [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency
Resolved	ovasileva	T232943 Logout button on mobile web misaligned

Event Timeline

Force_Radical created this task.Sep 15 2019, 4:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2019, 4:26 AM

Masumrezarock100 subscribed.Sep 15 2019, 8:36 AM

True, I've noticed it as well.
Here's the screenshot of a page from Wikimedia Commons.

Screenshot_20190915-140803.png (480×960 px, 53 KB)

Removing Wikimedia-production-error (see its description) and Web-Team-Backlog (it's up to teams what they would like to have on their list) tags. Assuming this is about MobileFrontend and/or MinervaNeue. :)

Kizule claimed this task.Sep 15 2019, 11:02 AM

Restricted Application added a project: User-Kizule. · View Herald TranscriptSep 15 2019, 11:02 AM

I think this is good, right?

Patch coming soon.

BTW, I changed in console property in .mw-ui-icon:before which was top: 0 to top: initial but I can't find correct file where I should change this. Anyone to help me?

I tried to use VPS-project-Codesearch but I found nothing.

In T232943#5493880, @Zoranzoki21 wrote:

I think this is good, right?

Patch coming soon.

Yeah it is good.

I will unassign this task from me because I can't make patch, but I will be still subscribed.

I am sure FR could solve this easily. But unfortunately he is not allowed to contribute to Gerrit anymore.

In T232943#5493989, @Masumrezarock100 wrote:

I am sure FR could solve this easily. But unfortunately he is not allowed to contribute to Gerrit anymore.

Who?

Nope, I am allowed to contribute it seems... That was a major mixup ....

In T232943#5493989, @Masumrezarock100 wrote:

I am sure FR could solve this easily. But unfortunately he is not allowed to contribute to Gerrit anymore.

In T232943#5494099, @Force_Radical wrote:

Nope, I am allowed to contribute it seems... That was a major mixup ....

Good to hear. :) Would it be possible for you to fix this bug?

Possibly caused by this commit. I don't think we need to do anything here since the offending code has already been overwritten by another commit.

Per above, the bug doesn't exist in the deployment clusters and thus will probably be fixed when the new mediawiki version rolls out.

Thanks for flagging, we did notice this and fix this as part of a wider change, but I'd like to reopen so we make sure to check this again.

Jdlrobson assigned this task to • alexhollender_WMF.Sep 16 2019, 6:00 PM

Jdlrobson moved this task from Needs Analysis to Needs Design Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdlrobson added a parent task: T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency.

ovasileva triaged this task as High priority.Sep 17 2019, 9:35 AM

Fixed

IMG_93AB5F7A4338-1.jpeg (1×750 px, 222 KB)

Kizule added a comment.Sep 17 2019, 5:57 PM

This comment was removed by Kizule.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX, Galaxy S5, iPad Pro, Google Pixel 2, Galaxy Note 3

Test Artifact(s):
✅ AC1 - Login button is centered in container.

Edtadros updated the task description. (Show Details)Sep 19 2019, 2:18 PM

Edtadros reassigned this task from Edtadros to ovasileva.Sep 19 2019, 2:29 PM

Edtadros moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Edtadros subscribed.

Looks good!

	F30355655: Screenshot_20190915-140803.png
	Sep 15 2019, 8:40 AM

	F30353578: Screenshot_20190915-095137.png
	Sep 15 2019, 4:26 AM

	F30398260: T232943.png
	Sep 19 2019, 2:16 PM

	F30358861: image.png
	Sep 15 2019, 11:09 AM

	F30358858: image.png
	Sep 15 2019, 11:04 AM

Logout button on mobile web misalignedClosed, ResolvedPublicActions