Cannot clear MediaInfo entities
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	LucasWerkmeister
	Sep 22 2019, 3:20 PM

Description

The clear boolean parameter of the wbeditentity API apparently cannot be used on MediaInfo entities:

{
    "error": {
        "code": "param-illegal",
        "info": "An illegal set of parameters have been used.",
        "messages": [
            {
                "name": "wikibase-api-param-illegal",
                "parameters": [],
                "html": {
                    "*": "An illegal set of parameters have been used."
                }
            }
        ]
    }
}

I assume this is because the MediaInfo class doesn’t implement the ClearableEntity interface. It had a clear() method for a while, but that was removed in T204488 (cc @Cparle, @Addshore).

Details

	Subject	Repo	Branch	Lines +/-
	Make MediaInfo implement ClearableEntity	mediawiki/extensions/WikibaseMediaInfo	master	+41 -2

Customize query in gerrit

Related Objects

Mentioned Here: T204488: Wikibase\MediaInfo\DataModel\MediaInfo must implement method `clear`

Event Timeline

LucasWerkmeister created this task.Sep 22 2019, 3:20 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptSep 22 2019, 3:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

My motivation for this is that I’m trying to write browser tests for the AC/DC gadget, for which I need a way to reset an entity to a known good state before I start editing it. As far as I can tell, there’s currently no good way to do that – I can’t find a “restore” in the API, and without the clear parameter, I’d have to explicitly remove all the statements in wbeditentity.

Change 538424 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseMediaInfo@master] Make MediaInfo implement ClearableEntity

https://gerrit.wikimedia.org/r/538424

gerritbot added a project: Patch-For-Review.Sep 22 2019, 3:40 PM

Lucas_Werkmeister_WMDE claimed this task.Sep 22 2019, 4:17 PM