Page MenuHomePhabricator

Jade unit test fails after api changes in SpamBlacklist
Closed, DuplicatePublic

Description

The SpamBlacklist extension was changed in the way its report errors through the api: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SpamBlacklist/+/526829/

The Jade extension is using this api and now failing unit tests:
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/22605/console

There was 1 error:

1) Jade\Tests\SpamBlacklist\SpamBlacklistTest::testFilterJudgment_matching
ApiUsageException: The text you wanted to save was blocked by the spam filter. This is probably caused by a link to a blacklisted external site. The following text is what triggered our spam filter: unusual-stringy

/workspace/src/includes/api/ApiBase.php:2106
/workspace/src/includes/api/ApiEditPage.php:401
/workspace/src/includes/api/ApiMain.php:1588
/workspace/src/includes/api/ApiMain.php:506
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:106
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:135
/workspace/src/extensions/Jade/tests/phpunit/SpamBlacklist/SpamBlacklistTest.php:83
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:454
/workspace/src/maintenance/doMaintenance.php:99